Add Lockdown Mode warning sheet for iOS editor#418
Merged
Conversation
jkmassel
force-pushed
the
jkmassel/ios-lockdown-banner
branch
5 times, most recently
from
af5e39b to
657bc97
Compare
jkmassel
force-pushed
the
jkmassel/ios-lockdown-banner
branch
from
657bc97 to
16f3b4d
Compare
dcalhoun
reviewed
Apr 3, 2026
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Implementation looks solid, but I shared a few concerns regarding the experience. I'm curious of your thoughts on those.
When iOS Lockdown Mode is enabled, WebKit JIT compilation is disabled, which can degrade the editor's performance and functionality. This adds detection via WKWebpagePreferences and presents a warning sheet with a link to Apple's support article on excluding apps from Lockdown Mode. - Detect lockdown mode after WebView navigation completes - Present dismissible half-sheet with warning and "Learn More" link - Re-check on foreground return to handle Settings changes - Skip editor autofocus when lockdown mode is active - All strings routed through EditorLocalization for host app overrides Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jkmassel
force-pushed
the
jkmassel/ios-lockdown-banner
branch
from
16f3b4d to
840926f
Compare
dcalhoun
approved these changes
Apr 10, 2026
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Latest changed tested well for me. The previously reported issues are no longer present. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ref CMM-2014.
WKWebpagePreferences.isLockdownModeEnabledafter WebView navigation completesEditorLocalizationso host apps can provide translationsTest plan
LockdownModeMonitorTests(CI will do this)Known issue
Type some text then switch to settings and back – the contents of the editor are lost.
🤖 Generated with Claude Code