feat(android): add photos and camera media strip to block inserter#479
Draft
jkmassel wants to merge 1 commit intojkmassel/block-picker-searchfrom
Draft
feat(android): add photos and camera media strip to block inserter#479jkmassel wants to merge 1 commit intojkmassel/block-picker-searchfrom
jkmassel wants to merge 1 commit intojkmassel/block-picker-searchfrom
Conversation
jkmassel
added a commit
that referenced
this pull request
Apr 28, 2026
Compose-based bottom sheet that replaces the legacy WebView block picker. Variation B handoff: drag handle + header, tonal Material 3 palette (dynamic on API 31+, brand-seeded fallback below), 5-column tile grid with auto-shrinking labels, scrollable category-tab chips, and a rounded search field. Block tiles render plain tonal rounded-rect placeholders for now — SVG icon rendering lands in #468 (which adds `SvgIconCache` and pipes `iconForeground` through the JS payload + iOS/Android models). This PR deliberately stops at the shell so #468 can be reviewed independently. Tab filter, search filter, photo/camera tiles, and recent-photo strip ship in #478 / #479 — the chips and search bar are intentionally non-functional in this PR so the visual shell can be reviewed in isolation.
7333438 to
43be5d0
Compare
9d824ee to
d3a1169
Compare
43be5d0 to
bfc85d9
Compare
3 tasks
jkmassel
added a commit
that referenced
this pull request
Apr 28, 2026
Compose-based bottom sheet that replaces the legacy WebView block picker. Variation B handoff: drag handle + header, tonal Material 3 palette (dynamic on API 31+, brand-seeded fallback below), 5-column tile grid with auto-shrinking labels, scrollable category-tab chips, and a rounded search field. Block tiles render plain tonal rounded-rect placeholders for now — SVG icon rendering lands in #468 (which adds `SvgIconCache` and pipes `iconForeground` through the JS payload + iOS/Android models). This PR deliberately stops at the shell so #468 can be reviewed independently. Tab filter, search filter, photo/camera tiles, and recent-photo strip ship in #478 / #479 — the chips and search bar are intentionally non-functional in this PR so the visual shell can be reviewed in isolation.
43be5d0 to
d2a4a4c
Compare
d3a1169 to
c966d1c
Compare
d2a4a4c to
b067ac2
Compare
jkmassel
added a commit
that referenced
this pull request
Apr 28, 2026
Compose-based bottom sheet that replaces the legacy WebView block picker. Variation B handoff: drag handle + header, tonal Material 3 palette (dynamic on API 31+, brand-seeded fallback below), 5-column tile grid with auto-shrinking labels, scrollable category-tab chips, and a rounded search field. Block tiles render plain tonal rounded-rect placeholders for now — SVG icon rendering lands in #468 (which adds `SvgIconCache` and pipes `iconForeground` through the JS payload + iOS/Android models). This PR deliberately stops at the shell so #468 can be reviewed independently. Tab filter, search filter, photo/camera tiles, and recent-photo strip ship in #478 / #479 — the chips and search bar are intentionally non-functional in this PR so the visual shell can be reviewed in isolation.
c966d1c to
4cc843e
Compare
jkmassel
added a commit
that referenced
this pull request
Apr 28, 2026
Compose-based bottom sheet that replaces the legacy WebView block picker. Variation B handoff: drag handle + header, tonal Material 3 palette (dynamic on API 31+, brand-seeded fallback below), 5-column tile grid with auto-shrinking labels, scrollable category-tab chips, and a rounded search field. Block tiles render plain tonal rounded-rect placeholders for now — SVG icon rendering lands in #468 (which adds `SvgIconCache` and pipes `iconForeground` through the JS payload + iOS/Android models). This PR deliberately stops at the shell so #468 can be reviewed independently. Tab filter, search filter, photo/camera tiles, and recent-photo strip ship in #478 / #479 — the chips and search bar are intentionally non-functional in this PR so the visual shell can be reviewed in isolation.
b067ac2 to
180a9b7
Compare
4cc843e to
5dbe8f3
Compare
jkmassel
added a commit
that referenced
this pull request
Apr 29, 2026
Compose-based bottom sheet that replaces the legacy WebView block picker. Variation B handoff: drag handle + header, tonal Material 3 palette (dynamic on API 31+, brand-seeded fallback below), 5-column tile grid with auto-shrinking labels, scrollable category-tab chips, and a rounded search field. Block tiles render plain tonal rounded-rect placeholders for now — SVG icon rendering lands in #468 (which adds `SvgIconCache` and pipes `iconForeground` through the JS payload + iOS/Android models). This PR deliberately stops at the shell so #468 can be reviewed independently. Tab filter, search filter, photo/camera tiles, and recent-photo strip ship in #478 / #479 — the chips and search bar are intentionally non-functional in this PR so the visual shell can be reviewed in isolation.
Base automatically changed from
jkmassel/block-picker-organize-impl
to
jkmassel/android-block-picker
April 29, 2026 16:18
jkmassel
added a commit
that referenced
this pull request
Apr 29, 2026
Compose-based bottom sheet that replaces the legacy WebView block picker. Variation B handoff: drag handle + header, tonal Material 3 palette (dynamic on API 31+, brand-seeded fallback below), 5-column tile grid with auto-shrinking labels, scrollable category-tab chips, and a rounded search field. Block tiles render plain tonal rounded-rect placeholders for now — SVG icon rendering lands in #468 (which adds `SvgIconCache` and pipes `iconForeground` through the JS payload + iOS/Android models). This PR deliberately stops at the shell so #468 can be reviewed independently. Tab filter, search filter, photo/camera tiles, and recent-photo strip ship in #478 / #479 — the chips and search bar are intentionally non-functional in this PR so the visual shell can be reviewed in isolation.
dfaf054 to
4067726
Compare
5dbe8f3 to
a878277
Compare
f9ac5cd to
8a32386
Compare
d8ae56e to
79c5380
Compare
0b46806 to
7e42816
Compare
Adds the recent-photos / Photos / Camera strip between the inserter
header and category tabs. Three states, picked at runtime:
1. **Permission rationale card** — shown when the host app hasn't yet
been granted READ_MEDIA_IMAGES. The card switches body copy and
primary-button label based on whether we've never asked, were
denied once, or were permanently denied. SharedPreferences tracks
the first prompt because `shouldShowRequestPermissionRationale`
alone can't distinguish "never asked" from "permanently denied".
2. **Recent photos strip** — once granted, queries MediaStore for the
12 most recent images and renders them as 2-row thumbnail tiles.
3. **Photos / Camera tiles** — Photos launches the system photo
picker (permissionless via `PickVisualMedia`); Camera launches
`ACTION_IMAGE_CAPTURE` against a cache-scoped FileProvider URI.
Hand-off of the picked URI to editor insertion is a follow-up.
The library declares its own FileProvider keyed off `${applicationId}`
so it won't collide with one a host app already provides. Host apps
that don't need photo access can `tools:node="remove"` the manifest
permissions.
7e42816 to
4a31671
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the recent-photos / Photos / Camera strip between the inserter header and category tabs. Stacked on top of #469; rebase onto
trunkonce that lands. Independent of #478 (search/filter PR) — they touch different parts ofSheetContent.Three runtime states:
READ_MEDIA_IMAGES. The card swaps body copy and primary button label depending on whether we've never asked, were denied once, or were permanently denied. SharedPreferences tracks the first prompt becauseshouldShowRequestPermissionRationalealone can't distinguish "never asked" from "permanently denied".PickVisualMedia); Camera launchesACTION_IMAGE_CAPTUREagainst a cache-scoped FileProvider URI. Hand-off of the picked URI to editor insertion is a follow-up.The library declares its own FileProvider keyed off
\${applicationId}so it won't collide with one a host app already provides. Hosts that don't need photo access cantools:node=\"remove\"the manifest permissions.Test plan