-
Notifications
You must be signed in to change notification settings - Fork 3
ci(ios): publish tagged releases as binary targets via Buildkite #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| if [[ -z "${NEW_VERSION:-}" ]]; then | ||
| echo "ERROR: NEW_VERSION is not set or is empty." >&2 | ||
| echo "Set NEW_VERSION=vX.Y.Z when triggering this build." >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo '--- :robot_face: Use bot for Git operations' | ||
| source use-bot-for-git | ||
|
|
||
| echo '--- :arrow_down: Downloading XCFramework artifacts' | ||
| buildkite-agent artifact download '*.xcframework.zip' . --step "build-xcframework" | ||
| buildkite-agent artifact download '*.xcframework.zip.checksum.txt' . --step "build-xcframework" | ||
|
|
||
| echo '--- :rubygems: Setting up Gems' | ||
| install_gems | ||
|
|
||
| echo "--- :rocket: Publishing Swift release $NEW_VERSION" | ||
| bundle exec fastlane release "version:$NEW_VERSION" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -31,9 +31,9 @@ Make sure the path points to your local GutenbergKit clone relative to your Word | |
|
|
||
| 1. Copy `local-builds.gradle-example` to `local-builds.gradle` | ||
| 2. Uncomment the `localGutenbergKitPath` line and set it to your local GutenbergKit path: | ||
| ```groovy | ||
| localGutenbergKitPath = "../GutenbergKit" | ||
| ``` | ||
| ```groovy | ||
| localGutenbergKitPath = "../GutenbergKit" | ||
| ``` | ||
| 3. Run Gradle sync — this substitutes the Maven dependency with the local project | ||
|
|
||
| ### Git Revision | ||
|
|
@@ -72,7 +72,7 @@ CI (Buildkite) publishes builds for PRs to the Maven repository automatically. | |
|
|
||
| **Use case**: Integrating GutenbergKit work into WordPress app trunk before a formal release. | ||
|
|
||
| Pre-releases create alpha version tags without creating a GitHub Release. They're useful for getting changes into the WordPress apps' main branches early. | ||
| Pre-releases create alpha version tags with a GitHub Release marked `--prerelease`. They're useful for getting changes into the WordPress apps' main branches early. | ||
|
|
||
| #### Creating a Pre-release | ||
|
|
||
|
|
@@ -89,7 +89,7 @@ Available version types: | |
| - `premajor` — increments major and adds alpha suffix (0.13.2 → 1.0.0-alpha.0) | ||
| - `prerelease` — increments the alpha number (0.13.3-alpha.0 → 0.13.3-alpha.1) | ||
|
|
||
| This pushes a git tag (e.g., `v0.13.3-alpha.0`) and CI publishes the Android build to the Maven repository. | ||
| Every trunk push already publishes per-commit artifacts (Android → Maven, iOS → S3 keyed by commit SHA). This bumps the version on `trunk` so the next per-commit publish carries that version, and the follow-up Buildkite build triggered with `NEW_VERSION=v0.13.3-alpha.0` adds the `vX.Y.Z` tag, the binary-target `Package.swift`, and the GitHub prerelease. See [Release Process](./releases.md) for the full flow. | ||
|
|
||
| #### iOS | ||
|
|
||
|
|
@@ -127,7 +127,7 @@ Available version types: | |
| - `minor` — new features, backwards compatible (0.13.2 → 0.14.0) | ||
| - `major` — breaking changes (0.13.2 → 1.0.0) | ||
|
|
||
| This creates a GitHub Release with auto-generated notes and CI publishes the Android build to the Maven repository. | ||
| Every trunk push already publishes per-commit artifacts (Android → Maven, iOS → S3 keyed by commit SHA). This bumps the version on `trunk` so the next per-commit publish carries that version, and the follow-up Buildkite build triggered with `NEW_VERSION=v0.13.3` adds the `vX.Y.Z` tag, the binary-target `Package.swift`, and the GitHub Release. See [Release Process](./releases.md) for the full flow. | ||
|
|
||
| #### iOS | ||
|
|
||
|
|
@@ -147,12 +147,12 @@ gutenberg-kit = '0.13.3' | |
|
|
||
| ## Workflow Recommendations | ||
|
|
||
| | Scenario | Recommended Method | | ||
| | --------------------------------- | ------------------ | | ||
| | Active feature development | Local Development | | ||
| | PR review / testing | Git Revision | | ||
| | Merging to WordPress app trunk | Pre-release | | ||
| | WordPress app release | Formal Release | | ||
| | Scenario | Recommended Method | | ||
| | ------------------------------ | ------------------ | | ||
| | Active feature development | Local Development | | ||
| | PR review / testing | Git Revision | | ||
| | Merging to WordPress app trunk | Pre-release | | ||
| | WordPress app release | Formal Release | | ||
|
Comment on lines
-150
to
+155
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nice |
||
|
|
||
| ## Platform-Specific Notes | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.