Skip to content

fix(release): replace invalid remove_lane_context_values in validate lane#520

Merged
jkmassel merged 1 commit into
trunkfrom
jkmassel/fix-validate-lane-context-cleanup
May 27, 2026
Merged

fix(release): replace invalid remove_lane_context_values in validate lane#520
jkmassel merged 1 commit into
trunkfrom
jkmassel/fix-validate-lane-context-cleanup

Conversation

@jkmassel
Copy link
Copy Markdown
Contributor

@jkmassel jkmassel commented May 27, 2026

What?

Fixes the validate Fastlane lane that gates tagged releases. Replaces a call to a non-existent action with the canonical Fastlane idiom for deleting lane-context values.

Why?

Build #2363 (the 0.17.0 release) failed at the :white_check_mark: Validate Swift release v0.17.0 step with:

Could not find action, lane or variable 'remove_lane_context_values'

remove_lane_context_values isn't a real Fastlane action. The call was introduced in #502 but never exercised by an actual release until the 0.17.0 attempt, which is why CI didn't catch it earlier. Because :rocket: Publish Swift release depends_on: validate-release, the tag was never pushed and no public artifact (tag, GH Release, or gutenbergkit/v0.17.0/ on S3) was ever produced.

How?

lane_context is a built-in Fastlane action that returns Actions.lane_context — a Hash subclass. Use Hash#delete directly:

[
  SharedValues::GITHUB_API_RESPONSE,
  SharedValues::GITHUB_API_STATUS_CODE,
  SharedValues::GITHUB_API_JSON
].each { |key| lane_context.delete(key) }

The defensive cleanup intent (clear the probe values so a later action doesn't see stale state) is preserved — only the syntax changes.

Testing Instructions

validate is read-only (checks version format, probes git for an existing tag, probes GitHub for an existing release) — safe to run locally:

bundle install
GITHUB_TOKEN=$(gh auth token) bundle exec fastlane validate version:v0.17.1

Expected: fastlane.tools finished successfully, with setup_ci, git_tag_exists, and get_github_release in the action summary, and no Could not find action error from the cleanup block.

  • ruby -c fastlane/Fastfile passes (syntax check)
  • bundle exec fastlane validate version:v0.17.1 passes locally

…ntext.delete

`remove_lane_context_values` isn't a Fastlane action — the `validate` lane
failed at runtime in build 2363 with `Could not find action, lane or
variable 'remove_lane_context_values'`, which gated `Publish Swift
release` and prevented the v0.17.0 tag from being pushed. Replace with
the canonical `lane_context.delete(key)` idiom.
@github-actions github-actions Bot added the [Type] Bug An existing feature does not function as intended label May 27, 2026
@wpmobilebot
Copy link
Copy Markdown

XCFramework Build

This PR's XCFramework is available for testing. Add the following to your Package.swift:

.package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/520")

Built from 3e711bc

@jkmassel jkmassel requested a review from oguzkocer May 27, 2026 18:06
@jkmassel jkmassel self-assigned this May 27, 2026
@jkmassel jkmassel enabled auto-merge (squash) May 27, 2026 18:06
@jkmassel jkmassel merged commit c18beb9 into trunk May 27, 2026
27 checks passed
@jkmassel jkmassel deleted the jkmassel/fix-validate-lane-context-cleanup branch May 27, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants