This repository was archived by the owner on Jun 19, 2025. It is now read-only.
Issue/135: Don't silently pass through face up/down device orientations #155
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #135.
The camera preview image was getting flipped when holding the device in portrait and then tilting it forward (as though you were going to point it downwards). This seemed to be because we were casting
UIDeviceOrientationdirectly toAVCaptureVideoOrientation, butAVCaptureVideoOrientationhas two extra Face Up / Face Down cases that the AV enum doesn't have. To fix the issue, we convert either of those cases toAVCaptureVideoOrientationPortrait.To test:
Needs review: @SergioEstevao