Skip to content
This repository was archived by the owner on Jun 19, 2025. It is now read-only.

Issue/135: Don't silently pass through face up/down device orientations #155

Merged
merged 2 commits into from
Mar 14, 2017
Merged

Issue/135: Don't silently pass through face up/down device orientations #155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0f3f67
Fixes #135: Don't silently pass through face up/down device orientations
frosty Mar 14, 2017
cb1974c
Updated orientation changes to use UIInterfaceOrientation.
frosty Mar 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions Pod/Classes/WPMediaCapturePreviewCollectionView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ - (void)startCapture
self.captureVideoPreviewLayer = [[AVCaptureVideoPreviewLayer alloc] initWithSession:self.session];
self.captureVideoPreviewLayer.videoGravity = AVLayerVideoGravityResizeAspectFill;
self.captureVideoPreviewLayer.frame = viewLayer.bounds;
self.captureVideoPreviewLayer.connection.videoOrientation = (AVCaptureVideoOrientation)[[UIDevice currentDevice] orientation];
self.captureVideoPreviewLayer.connection.videoOrientation = [self videoOrientationForInterfaceOrientation:[[UIApplication sharedApplication] statusBarOrientation]];
[viewLayer addSublayer:_captureVideoPreviewLayer];
});
}
Expand All @@ -110,7 +110,22 @@ - (void)startCapture
- (void)deviceOrientationDidChange:(NSNotification *)notification
{
if (self.captureVideoPreviewLayer.connection.supportsVideoOrientation) {
self.captureVideoPreviewLayer.connection.videoOrientation = (AVCaptureVideoOrientation)[[UIDevice currentDevice] orientation];
self.captureVideoPreviewLayer.connection.videoOrientation = [self videoOrientationForInterfaceOrientation:[[UIApplication sharedApplication] statusBarOrientation]];
}
}

- (AVCaptureVideoOrientation)videoOrientationForInterfaceOrientation:(UIInterfaceOrientation)orientation
{
switch (orientation) {
case UIInterfaceOrientationPortrait:
return AVCaptureVideoOrientationPortrait;
case UIInterfaceOrientationPortraitUpsideDown:
return AVCaptureVideoOrientationPortraitUpsideDown;
case UIInterfaceOrientationLandscapeLeft:
return AVCaptureVideoOrientationLandscapeLeft;
case UIInterfaceOrientationLandscapeRight:
return AVCaptureVideoOrientationLandscapeRight;
default:return AVCaptureVideoOrientationPortrait;
}
}

Expand Down