Remove HistoryListFragment.onSaveInstanceState

[shiki]

Fixes #10401.

Findings

This was caused by the “fix” in #10240. The only way I could think of why this happens is this scenario:

1. The user opens the editor and opens the History page.
2. There's a delay in loading the Post data in HistoryViewModel.
3. The user immediately puts the app in the background.
4. State saving kicks in and crashes because the HistoryViewModel wasn't fully initialized yet.

I can consistently reproduce this scenario by adding a delay(). To do that, change the val post: PostModel? line in HistoryViewModel.create() to this:

val post: PostModel? = withContext(bgDispatcher) {
    kotlinx.coroutines.delay(5_000)
    postStore.getPostByLocalPostId(localPostId)
}

This adds a 5 second delay of the loading. Turn on Don't keep activities in your device's Developer options. And then perform the steps above. The app should crash.

Solution

I removed the onSaveInstanceState of HistoryListFragment. It looks like we do not use that key anyway. We rely on the Fragment arguments to load the SiteModel. Using the arguments for state restoration should be enough since they should be retained automatically.

Testing

Please repeat the steps described in the Findings section and validate that the app does not crash anymore.

Reviewing

Only 1 reviewer is needed but anyone can review.

Release Notes

• If there are user-facing changes, I have added an item to RELEASE-NOTES.txt.

[maxme]

It looks like we do not use that key anyway.

Yep, I had a look at the history and from the first version it seems unused. I also checked that the viewModel couldn't be used beforeviewModel.create in this file.

Using the arguments for state restoration should be enough since they should be retained automatically.

Looks good, the post id and the SiteModel will be restored.