Unified Login & Sign-Up: Stop tracking unnecessary error when signing up with Google

[renanferrari]

After shipping the unified login & sign-up flow we noticed an increased number of "social login failures", which would indicate more people were not being able to login with their Google accounts. Upon further examination we determined that this wasn't true and that the increased number of failures was because we now always try to login first and only start the signup flow after we receive an UNKNOWN_USER error.

Since this is an expected error and is needed for the flow to continue, this PR introduces a change to prevent it from being tracked.

Login-Flow counterpart: wordpress-mobile/WordPress-Login-Flow-Android#43

To test

Note: before you start, make sure you have setup your environment to support Google Sign-Ins (internal reference: paqN3M-9M-p2).

0. Clear app data.
1. On the Prologue Screen, tap Continue with WordPress.com.
2. On the Email Screen, tap Continue with Google.
3. Pick a Google account that is not associated with a WordPress.com account.
4. Notice the Sign-Up Confirmation screen.
5. Notice the following events in Logcat:
   • unified_login_step, Properties: {"source":"default","flow":"google_login","step":"start"}
   • unified_login_step, Properties: {"source":"default","flow":"google_signup","step":"start"}
6. Verify that you don't see any of the following events:
   • login_failed_to_login, Properties: {"error_context":"OnSocialChanged","error_description":"[...]","error_type":"UNKNOWN_USER"}
   • login_social_failure, Properties: {"error_context":"OnSocialChanged","error_description":"[...]","error_type":"UNKNOWN_USER"}

---

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[peril-wordpress-mobile]

Messages

📖

This PR contains changes in the subtree libs/login/. It is your responsibility to ensure these changes are merged back into wordpress-mobile/WordPress-Login-Flow-Android. Follow these handy steps! WARNING: Make sure your git version is 2.19.x or lower - there is currently a bug in later versions that will corrupt the subtree history! cd WordPress-Android git checkout fix/google-login-unknown-user-error git subtree push --prefix=libs/login/ https://github.com/wordpress-mobile/WordPress-Login-Flow-Android.git merge/WordPress-Android/12727 Browse to https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/new/merge/WordPress-Android/12727 and open a new PR.

Generated by 🚫 dangerJS

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading the APK here.

[khaykov]

Looks good 👍 I confirmed successful Logcat messages and no errors.