Login: Update behavior when logging in with a Jetpack site so it defaults to using site credentials instead of WP.com credentials #13065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renanferrari
requested review from
develric,
khaykov,
loremattei and
planarvoid
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
renanferrari
force-pushed
the
issue/13064-jetpack-site-users
branch
3 times, most recently
from
6ed6622 to
bd7f201
Compare
renanferrari
force-pushed
the
issue/13064-jetpack-site-users
branch
from
bd7f201 to
6d214c4
Compare
|
You can test the changes on this Pull Request by downloading the APK here. |
khaykov
approved these changes
Oct 7, 2020
Contributor
khaykov
left a comment
khaykov
left a comment
There was a problem hiding this comment.
I can confirm that the test scenario works as expected, and the code looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13064
This PR partially reverts the changes made by #12978 in order to redirect a user logging in with a Jetpack site address to the Username/Password screen instead of the Get Started screen, so they can complete the flow using their site credentials instead of their WP.com credentials.
The new behavior is consistent with what we currently have on WPiOS.
To test:
* These are the site credentials, which are used to login to
wp-adminon the web.PR submission checklist:
RELEASE-NOTES.txtif necessary.