Skip to content

Adds composite build support for AztecEditor-Android #15432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Adds composite build support for AztecEditor-Android #15432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libs/editor/WordPressEditor/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ dependencies {
implementation 'com.android.volley:volley:1.1.1'
implementation 'org.wordpress:utils:1.25'
implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlinVersion"
api ("com.github.wordpress-mobile.WordPress-Aztec-Android:aztec:$aztecVersion") {
api ("$gradle.ext.aztecAndroidAztecPath:$aztecVersion") {
exclude group: "com.android.volley"
}
api ("com.github.wordpress-mobile.WordPress-Aztec-Android:wordpress-shortcodes:$aztecVersion")
api ("com.github.wordpress-mobile.WordPress-Aztec-Android:wordpress-comments:$aztecVersion")
api ("$gradle.ext.aztecAndroidWordPressShortcodesPath:$aztecVersion")
api ("$gradle.ext.aztecAndroidWordPressCommentsPath:$aztecVersion")

// This dependency will be substituted if the `local-builds.gradle` file contains
// `localGutenbergMobilePath`. Details for this can be found in the `settings.gradle` file.
Expand Down
1 change: 1 addition & 0 deletions local-builds.gradle-example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@ ext {
//localGutenbergMobilePath = "../gutenberg-mobile"
//localLoginFlowPath = "../WordPress-Login-Flow-Android"
//localStoriesAndroidPath = "../stories-android"
//localAztecAndroidPath = "../AztecEditor-Android"
}
18 changes: 18 additions & 0 deletions settings.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@ gradle.ext.loginFlowBinaryPath = "org.wordpress:login"
gradle.ext.storiesAndroidPath = "com.automattic:stories"
gradle.ext.storiesAndroidMp4ComposePath = "com.automattic.stories:mp4compose"
gradle.ext.storiesAndroidPhotoEditorPath = "com.automattic.stories:photoeditor"
gradle.ext.aztecAndroidAztecPath = "com.github.wordpress-mobile.WordPress-Aztec-Android:aztec"
gradle.ext.aztecAndroidWordPressShortcodesPath = "com.github.wordpress-mobile.WordPress-Aztec-Android:wordpress-shortcodes"
gradle.ext.aztecAndroidWordPressCommentsPath = "com.github.wordpress-mobile.WordPress-Aztec-Android:wordpress-comments"
gradle.ext.aztecAndroidGlideLoaderPath = "com.github.wordpress-mobile.WordPress-Aztec-Android:glide-loader"
gradle.ext.aztecAndroidPicassoLoaderPath = "com.github.wordpress-mobile.WordPress-Aztec-Android:picasso-loader"

def localBuilds = new File('local-builds.gradle')
if (localBuilds.exists()) {
Expand Down Expand Up @@ -85,6 +90,19 @@ if (localBuilds.exists()) {
}
}
}

if (ext.has("localAztecAndroidPath")) {
includeBuild(ext.localAztecAndroidPath) {
dependencySubstitution {
println "Substituting AztecEditor-Android with the local build"
substitute module("$gradle.ext.aztecAndroidAztecPath") with project(':aztec')
substitute module("$gradle.ext.aztecAndroidWordPressShortcodesPath") with project(':wordpress-shortcodes')
substitute module("$gradle.ext.aztecAndroidWordPressCommentsPath") with project(':wordpress-comments')
substitute module("$gradle.ext.aztecAndroidGlideLoaderPath") with project(':glide-loader')
substitute module("$gradle.ext.aztecAndroidPicassoLoaderPath") with project(':picasso-loader')
}
}
}
}

// Build cache is only enabled for CI, at least for now
Expand Down