-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Dependency Updates] Update jsoupVersion to 1.15.4
#18102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| App Name | Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18102-e98d7e8 | |
| Commit | e98d7e8 | |
| Direct Download | jetpack-prototype-build-pr18102-e98d7e8.apk |
|
| App Name | WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr18102-e98d7e8 | |
| Commit | e98d7e8 | |
| Direct Download | wordpress-prototype-build-pr18102-e98d7e8.apk |
Discussion: https://github.com/wordpress-mobile/WordPress-Android/pull/ 17066#discussion_r1135813549
|
Found 1 violations: The PR caused the following dependency changes: +--- project :libs:editor
| +--- org.wordpress:aztec:{strictly v1.6.3} -> v1.6.3
-| | \--- org.jsoup:jsoup:1.11.3
+| | \--- org.jsoup:jsoup:1.11.3 -> 1.15.4
-| \--- org.jsoup:jsoup:1.10.3 -> 1.11.3
-\--- org.jsoup:jsoup:1.10.3 -> 1.11.3
+\--- org.jsoup:jsoup:1.15.4
Please review and act accordingly
|
|
Hey there @ParaskP7 👋 I'm currently testing this PR following the instructions but I have a doubt about:
Thanks! |
|
👋 @geriux and thanks for starting your testing on this dependency update! 🙇
I think this has been discussed a few times already, but I can't find the latest on that. Short story long, to my knowledge, some sites are still have the ability to switch between the old and new editor. For example, while testing my site ( Maybe someone else more knowledgeable on that can help verify that for us... 🤔 |
That worked thanks! TIL. I thought this was removed 😄 |
geriux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
I've followed the test instructions and all is working correctly. Thanks for taking care of this!
|
Awesome, thanks so much for reviewing and testing this update @geriux ! 🙇 ❤️ 🚀 |


Parent #17569
This PR updates
jsoupVersionto 1.15.4.PS: @geriux @fluiddot I added you both as the main reviewers, not so randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.
PS: You might want to do a similar update on both, the Aztec and Gutenberg libraries, at some point too.
To test:
HTLMinto aDocumentand selecting anElementfrom it, on both, the WordPress and Jetpack apps, and see if they both work as expected.1. Classic Editor [Aztec]
ℹ️ Disable the
Block Editorbefore testing this.Postsscreen and create a new post.Image,Videoand any other entry (likeParagraph,Ordered List,Quote, etc).Classic Editorrelated post of yours is being displayed as expected, both when previewing it from within thePostsandReaderscreens. FYI: OnReader, you will find you post within theFOLLOWINGtab.2. Block Editor [Gutenberg]
ℹ️ Enable the
Block Editorbefore testing this.Postsscreen and create a new post.Image,Gallery,Video,Audio,File,Media TextandCoverblocks to the post.Block Editorrelated post of yours is being displayed as expected, both when previewing it from within thePostsandReaderscreens. FYI: OnReader, you will find you post within theFOLLOWINGtab.3. Reader Post Details [ReaderPostRenderer.java]
Readerscreen and click on various posts.4. Stats Insights - Latest Post Summary [LatestPostSummaryMapper.kt]
ℹ️ If the
Latest Post Summarycard is not being displayed, navigate to the bottom of theStatsscreen and click on theAdd new stats card. Then, enabled theLatest Post Summaryfrom within thePosts and Pagesgroup.Statsscreen and itsINSIGHTStab.Latest Post Summarycard and verify that it is being displayed as expected.Regression Notes
Potential unintended areas of impact
HTLMinto aDocumentand selecting anElementfrom it.What I did to test those areas of impact (or what existing automated tests I relied on)
To testsection above.What automated tests I added (or what prevented me from doing so)
PR submission checklist:
RELEASE-NOTES.txtif necessary.