Skip to content

Conversation

@ParaskP7
Copy link
Contributor

@ParaskP7 ParaskP7 commented Mar 14, 2023

Parent #17569

This PR updates jsoupVersion to 1.15.4.


PS: @geriux @fluiddot I added you both as the main reviewers, not so randomly, since I just wanted someone from the WordPress team to be aware of and sign-off on that change for WPAndroid. I also added the @wordpress-mobile/apps-infrastructure team, but this in done only for monitoring purposes, as such, I am not expecting any active review from that team. Thus, feel free to merge this PR if you deem so.

PS: You might want to do a similar update on both, the Aztec and Gutenberg libraries, at some point too.


To test:

  1. See the dependency tree diff result and verify correctness.
  2. Thoroughly smoke test any JSoup related functionality, which is mainly parsing HTLM into a Document and selecting an Element from it, on both, the WordPress and Jetpack apps, and see if they both work as expected.
  3. In addition to the above smoke test, you can expand the below and follow the inner and more explicit test steps within:
1. Classic Editor [Aztec]

ℹ️ Disable the Block Editor before testing this.

  • Go to Posts screen and create a new post.
  • Add an Image, Video and any other entry (like Paragraph, Ordered List, Quote, etc).
  • Publish this newly created post.
  • Verify that this newly created Classic Editor related post of yours is being displayed as expected, both when previewing it from within the Posts and Reader screens. FYI: On Reader, you will find you post within the FOLLOWING tab.
2. Block Editor [Gutenberg]

ℹ️ Enable the Block Editor before testing this.

  • Go to Posts screen and create a new post.
  • Add an Image, Gallery, Video, Audio, File, Media Text and Cover blocks to the post.
  • Publish this newly created post.
  • Verify that this newly created Block Editor related post of yours is being displayed as expected, both when previewing it from within the Posts and Reader screens. FYI: On Reader, you will find you post within the FOLLOWING tab.
3. Reader Post Details [ReaderPostRenderer.java]
  • Go to Reader screen and click on various posts.
  • Verify that each and every post, along with all their details is being displayed as expected.
4. Stats Insights - Latest Post Summary [LatestPostSummaryMapper.kt]

ℹ️ If the Latest Post Summary card is not being displayed, navigate to the bottom of the Stats screen and click on the Add new stats card. Then, enabled the Latest Post Summary from within the Posts and Pages group.

  • Go to Stats screen and its INSIGHTS tab.
  • Scroll to the Latest Post Summary card and verify that it is being displayed as expected.

Regression Notes

  1. Potential unintended areas of impact

    • Potential breakage or misbehaviour on any or all JSoup related app functionalities, like parsing HTLM into a Document and selecting an Element from it.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • See To test section above.
  3. What automated tests I added (or what prevented me from doing so)

    • N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 14, 2023

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr18102-e98d7e8
Commite98d7e8
Direct Downloadjetpack-prototype-build-pr18102-e98d7e8.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 14, 2023

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr18102-e98d7e8
Commite98d7e8
Direct Downloadwordpress-prototype-build-pr18102-e98d7e8.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Found 1 violations:

The PR caused the following dependency changes:

 +--- project :libs:editor
 |    +--- org.wordpress:aztec:{strictly v1.6.3} -> v1.6.3
-|    |    \--- org.jsoup:jsoup:1.11.3
+|    |    \--- org.jsoup:jsoup:1.11.3 -> 1.15.4
-|    \--- org.jsoup:jsoup:1.10.3 -> 1.11.3
-\--- org.jsoup:jsoup:1.10.3 -> 1.11.3
+\--- org.jsoup:jsoup:1.15.4

Please review and act accordingly

@ParaskP7 ParaskP7 requested review from a team, fluiddot and geriux March 15, 2023 12:53
@ParaskP7 ParaskP7 marked this pull request as ready for review March 15, 2023 12:53
@geriux
Copy link
Contributor

geriux commented Mar 24, 2023

Hey there @ParaskP7 👋 I'm currently testing this PR following the instructions but I have a doubt about:

Disable the Block Editor before testing this. As far as I know we don't allow disabling the Block Editor, is there a flag somewhere to disable it?

Thanks!

@ParaskP7
Copy link
Contributor Author

👋 @geriux and thanks for starting your testing on this dependency update! 🙇

Disable the Block Editor before testing this. As far as I know we don't allow disabling the Block Editor, is there a flag somewhere to disable it?

I think this has been discussed a few times already, but I can't find the latest on that. Short story long, to my knowledge, some sites are still have the ability to switch between the old and new editor.

For example, while testing my site (petrosatwork.blog), which is on a business plan, I just need to go to Site Settings, its Editor section and here I am seeing the Use Block Editor switch, which I can then switch on-and-off, just like it used to be working for all sites in the past. I don't think there is a debug flag somewhere, I think this is driven by the type of site itself. 🤷

Maybe someone else more knowledgeable on that can help verify that for us... 🤔

@geriux
Copy link
Contributor

geriux commented Mar 24, 2023

For example, while testing my site (petrosatwork.blog), which is on a business plan, I just need to go to Site Settings, its Editor section and here I am seeing the Use Block Editor switch, which I can then switch on-and-off, just like it used to be working for all sites in the past.

That worked thanks! TIL. I thought this was removed 😄

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

I've followed the test instructions and all is working correctly. Thanks for taking care of this!

@ParaskP7
Copy link
Contributor Author

Awesome, thanks so much for reviewing and testing this update @geriux ! 🙇 ❤️ 🚀

@ParaskP7 ParaskP7 merged commit 78ce780 into trunk Mar 24, 2023
@ParaskP7 ParaskP7 deleted the deps/update-jsoup-to-1.15.4 branch March 24, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants