Dangermattic checks update #20132
Merged
Dangermattic checks update #20132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
 |
App Name |  WordPress |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20132-49f63b4 | |
| Commit | 49f63b4 | |
| Direct Download | wordpress-prototype-build-pr20132-49f63b4.apk |
Contributor
|
 |
App Name |  Jetpack |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr20132-49f63b4 | |
| Commit | 49f63b4 | |
| Direct Download | jetpack-prototype-build-pr20132-49f63b4.apk |
iangmaia
force-pushed
the
iangmaia/dangermattic-update
branch
2 times, most recently
from
ddcb6fd to
78226e9
Compare
iangmaia
force-pushed
the
iangmaia/dangermattic-update
branch
from
78226e9 to
1ecc225
Compare
Generated by 🚫 dangerJS |
Collaborator
Generated by 🚫 Danger |
mokagio
approved these changes
Feb 14, 2024
Contributor
mokagio
left a comment
mokagio
left a comment
There was a problem hiding this comment.
Approving to unblock. The same comments from the Pocket Casts iOS PR apply here, Automattic/pocket-casts-ios#1418 (review), but none of them were blocking.
| # Add entries for `screenshot_*.txt` files as well | ||
| Dir.glob('screenshot_*.txt', base: metadata_folder).sort.each do |screenshot_file| | ||
| key = "play_store_#{File.basename(screenshot_file, '.txt')}".to_sym | ||
| key = :"play_store_#{File.basename(screenshot_file, '.txt')}" |
mokagio
added a commit
that referenced
this pull request
Dec 2, 2025
This Danger check was out of place as `WordPress/src/main/res/values/strings.xml` is the source of truth for localizations. Unlike in Apple projects, where we use `genstrings` to find localized strings in the codebase to assemble the `strings` file, in Android, as far as I understand, `<app>/src/main/res/valudes/strings.xml` is the source of truth. I believe this check ended up in `Dangerfile` accidentally. It was introduced in #20132. The update was done across our suite of apps, see for example woocommerce/woocommerce-android#10692 and woocommerce/woocommerce-ios#11926. Given I couldn't find a comment explicitly about adopting this check, I guess neither @iangmaia nor myself notice the same pattern as iOS was adopted in the Android repo. To reinforce the idea that this check is out of place, notice that WooCommerce Android does not implement the check. _Of course, it could be that WooCommerce is wrong, but lacking code to update `strings.xml` as part of the code freeze process, that explanation is not satisfying._
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adapts the
Dangerfileto the latest Dangermattic version, using newly added plugins, adapting the code as needed and implementing a few improvements.The main changes:
github_utilsplugin instead of locally declared functionsReleaseslabeldanger-dangermatticGemTesting
The main validation is to make sure CI is 🟢.
To run Danger yourself:
bundle installYou should get in the console the same errors / warnings reported in the PR.