Merged
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name |  Jetpack |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21457-ba6d8d6 | |
| Commit | ba6d8d6 | |
| Direct Download | jetpack-prototype-build-pr21457-ba6d8d6.apk |
Contributor
|
| App Name |  WordPress |
|
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr21457-ba6d8d6 | |
| Commit | ba6d8d6 | |
| Direct Download | wordpress-prototype-build-pr21457-ba6d8d6.apk |
nbradbury
changed the title
…into issue/21451-avg-view-more-link
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21457 +/- ##
=======================================
Coverage 39.50% 39.50%
=======================================
Files 2119 2119
Lines 99437 99437
Branches 15282 15282
=======================================
Hits 39281 39281
Misses 56674 56674
Partials 3482 3482 ☔ View full report in Codecov by Sentry. |
dcalhoun
approved these changes
Nov 13, 2024
Member
dcalhoun
left a comment
dcalhoun
left a comment
There was a problem hiding this comment.
Changes look sound, testing succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially resolves #21451
As noted in the issue, tapping this link in stats does nothing because this line of code explicitly states to do nothing.
It turns out this was simply due to fixing a warning about a non-exhaustive
whenclause.We don't have a screen for average daily views and creating one doesn't seem like a priority, so this PR simply removes the "View more" link. I've filed #21458 as a reminder that we should add that screen at some point to match iOS.