feat: Editor styles preferences align with web defaults #22306
Conversation
This is a more appropriate long-term location rather than experimental features.
This preference only impacts GutenbergKit.
The theme styles preference shares a parent preference section with the toggle for enabling the block editor.
The value is not tracked on the server, nor returned by the API response.
dcalhoun
added
[Type] Enhancement
Posting/Editing
Gutenberg
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22306-00afd40 | |
| Commit | 00afd40 | |
| Direct Download | wordpress-prototype-build-pr22306-00afd40.apk |
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22306-00afd40 | |
| Commit | 00afd40 | |
| Direct Download | jetpack-prototype-build-pr22306-00afd40.apk |
| mSettings.copyFrom(mRemoteSettings); | ||
| mSettings.postFormats = currentPostFormats; | ||
| mSettings.location = location; | ||
| mSettings.useThemeStyles = useThemeStyles; |
There was a problem hiding this comment.
Prevents a non-existent useThemeStyles value on the server clearing the value stored locally. The value is intentionally not persisted on the server.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22306 +/- ##
==========================================
- Coverage 39.48% 39.48% -0.01%
==========================================
Files 2188 2188
Lines 104662 104665 +3
Branches 14916 14916
==========================================
- Hits 41329 41325 -4
- Misses 59848 59855 +7
Partials 3485 3485 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Assuming this only happens when the experimental editor is enabled (it's mentioned in the next point)
2. Verify the toggle is visible for all site types:
- WPCOM Simple: displayed alone
- Non-WPCOM Simple: displayed alongside "Use block editor"
LGTM and works as expected!
Correct; if the experimental editor is disabled, then the theme styles toggle |
Wait, if the experimental editor is disabled, should the toggle BE visible in site settings? |
@adalpari forgive me, it was a typo in my response. My brain often simply leaves out typing "not." 🙃 If the experimental editor is disabled, the toggle should not be present. The toggle is only relevant when the experimental editor is enabled. |
|
With the experimental block editor DISABLED:
With the experimental block editor ENABLED: |
Description
Ref CMM-869.
Relocate editor's "Use theme styles" toggle to Site Settings rather than Experimental Features, as this is a better long-term location.
Enable theme styles by default to align with the web editor.
Testing instructions