Issue/cmm 1130 drop quick start #22477
Conversation
The site picker is no longer shown after any login flow. WPMainActivity automatically selects a default site when the user logs in. Changes: - Skip LoginEpilogueActivity in all login paths - Delete LoginEpilogueActivity, Fragment, ViewModel, and related code - Remove unused layouts (login_epilogue_*.xml) - Remove unused ViewModelModule binding - Clean up ActivityLauncher methods - Remove unused navigation events from LoginNavigationEvents - Remove item_divider references from SitePickerAdapter Login flows affected: - WordPress.com login (username/password) - WordPress.com login (Continue with WordPress.com) - Magic link login - Self-hosted login (Application Password) - All Jetpack login flows Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The site picker is no longer shown after any login flow. WPMainActivity automatically selects a default site when the user logs in. Changes: - Skip LoginEpilogueActivity in all login paths - Delete LoginEpilogueActivity, Fragment, ViewModel, and related code - Remove unused layouts (login_epilogue_*.xml) - Remove unused ViewModelModule binding - Clean up ActivityLauncher methods - Remove unused navigation events from LoginNavigationEvents - Remove item_divider references from SitePickerAdapter Login flows affected: - WordPress.com login (username/password) - WordPress.com login (Continue with WordPress.com) - Magic link login - Self-hosted login (Application Password) - All Jetpack login flows Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Keep the refactored version that reduces code duplication by using navigateToMainActivityOrFinish() and finishWithNewlyAddedSiteId() helper methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove unused LOGIN_EPILOGUE and SHOW_LOGIN_EPILOGUE_AND_RETURN from RequestCodes - Remove LOGIN_EPILOGUE from SiteCreationSource enum - Rename isNewLoginEpilogueScreenEnabled() to shouldShowAddSiteFooter() in SitePickerAdapter - Delete unused login_include_epilogue_sites_subheader_new.xml layout - Remove unused login_epilogue_* strings from strings.xml Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
…ubheader Rename the layout file and ID to better reflect its actual purpose (used by share intent feature, not login epilogue). - Rename layout file to share_intent_sites_subheader.xml - Rename ID to share_intent_sites_subheader - Update references in share_intent_receiver_header.xml - Update references in ShareIntentReceiverFragment.java Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Extract login completion decision logic from LoginActivity into a testable use case class. This provides comprehensive test coverage for the logic that was previously in LoginEpilogueViewModel. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This removes the Quick Start feature that guided new users through site setup tasks. The feature included: - Quick Start cards on the My Site dashboard - Focus points highlighting UI elements - Task tracking and completion - Reminder notifications Files removed: - ui/quickstart/* package (10 files) - ui/mysite/cards/quickstart/* package (6 files) - QuickStartPromptDialogFragment, QuickStartUtils, QuickStartFocusPoint - Related layouts, drawables, animations, and menus - ~55 QUICK_START_* analytics events Files modified: - MySiteViewModel, MySiteFragment, WPMainActivity - Various ViewModelSlices, ViewHolders, and builders - AppPrefs, AnalyticsTracker - Related test files Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Generated by 🚫 Danger |
Removes 75 Quick Start related strings from strings.xml that are no longer used after the Quick Start feature removal. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
| App Name | WordPress | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22477-9b728d5 | |
| Commit | 9b728d5 | |
| Direct Download | wordpress-prototype-build-pr22477-9b728d5.apk |
|
| App Name | Jetpack | |
| Flavor | Jalapeno | |
| Build Type | Debug | |
| Version | pr22477-9b728d5 | |
| Commit | 9b728d5 | |
| Direct Download | jetpack-prototype-build-pr22477-9b728d5.apk |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| // Flag to track when we're waiting for account/sites to load after OAuth login | ||
| private boolean mIsWaitingForSitesToLoad = false; | ||
| private ArrayList<Integer> mOldSitesIdsForLoginUpdate; |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on field Note
|
|
||
| @SuppressWarnings("unused") | ||
| @Subscribe(threadMode = ThreadMode.MAIN) | ||
| public void onAccountChanged(OnAccountChanged event) { |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on method parameter Note
|
|
||
| @SuppressWarnings("unused") | ||
| @Subscribe(threadMode = ThreadMode.MAIN) | ||
| public void onSiteChanged(OnSiteChanged event) { |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on method parameter Note
| /** | ||
| * Finds the newly added self-hosted site and finishes with its ID in the result intent. | ||
| */ | ||
| private void finishWithNewlyAddedSiteId(ArrayList<Integer> oldSitesIds) { |
Check notice
Code scanning / Android Lint
Nullable/NonNull annotation missing on method parameter Note
Remove unused imports and private members that became orphaned after removing the Quick Start feature, including: - Unused imports across multiple ViewModels and Fragments - Unused constructor parameters in MySiteViewModel - Unused private function in ReaderViewModelTest Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove unused imports in WPMainActivity (ViewGroup, MySiteViewModel) - Remove empty line before closing brace in WPMainActivity - Fix import ordering in MediaGridFragment Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Remove QuickStartReminderReceiver from AndroidManifest.xml - Delete unused drawable files (bg_oval_primary, ic_baseline_check_24, etc.) - Remove Quick Start colors from colors.xml and colors_base.xml - Remove Quick Start dimens from dimens.xml - Remove Quick Start styles from styles.xml and dashboard_card_styles.xml - Delete values-sw600dp/styles.xml (Quick Start only) - Remove Quick Start colors from values-night/colors.xml - Update feature_introduction_dialog_fragment.xml button style - Remove unused WordPress.FullscreenDialog.NoTitle style - Remove unused Jetpack resources (primary_0 color, ic_reader_white_24dp) - Rename MySiteCardQuickStartItemTitle to MySiteCardItemTitle Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/base_manifest.txt 2026-01-13 23:25:18.450317024 +0000
+++ ./build/reports/diff_manifest/WordPress/jetpackVanillaRelease/head_manifest.txt 2026-01-13 23:25:20.800314337 +0000
@@ -1240,7 +1240,6 @@
<action android:name="com.android.vending.INSTALL_REFERRER" />
</intent-filter>
</receiver>
- <receiver android:name="org.wordpress.android.ui.quickstart.QuickStartReminderReceiver" />
<receiver android:name="org.wordpress.android.ui.posts.PublishNotificationReceiver" /> <!-- Google Cloud Messaging receiver and services -->
<meta-data
android:name="com.google.android.gms.version"Go to https://buildkite.com/automattic/wordpress-android/builds/24440/canvas?sid=019bb9a9-5a55-480c-b3de-a1aea77736e0, click on the |
Project manifest changes for WordPressThe following changes in the --- ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/base_manifest.txt 2026-01-13 23:24:49.679327614 +0000
+++ ./build/reports/diff_manifest/WordPress/wordpressVanillaRelease/head_manifest.txt 2026-01-13 23:24:52.039343387 +0000
@@ -1213,7 +1213,6 @@
<action android:name="com.android.vending.INSTALL_REFERRER" />
</intent-filter>
</receiver>
- <receiver android:name="org.wordpress.android.ui.quickstart.QuickStartReminderReceiver" />
<receiver android:name="org.wordpress.android.ui.posts.PublishNotificationReceiver" /> <!-- Google Cloud Messaging receiver and services -->
<meta-data
android:name="com.google.android.gms.version"Go to https://buildkite.com/automattic/wordpress-android/builds/24440/canvas?sid=019bb9a9-5a54-4141-8994-c208c6ff6023, click on the |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## trunk #22477 +/- ##
==========================================
- Coverage 39.17% 38.94% -0.23%
==========================================
Files 2205 2189 -16
Lines 106599 105349 -1250
Branches 15117 14943 -174
==========================================
- Hits 41761 41031 -730
+ Misses 61339 60888 -451
+ Partials 3499 3430 -69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
The activeQuickStartItem and showFocusPoint properties were left over from the Quick Start feature removal. These properties were all hardcoded to false and no longer served any purpose. Removed: - activeQuickStartItem property from MySiteCardAndItem and subclasses - showTitleFocusPoint, showSubtitleFocusPoint, showIconFocusPoint from SiteInfoHeaderCard - showMoreFocusPoint from QuickLinksItem - showFocusPoint from QuickLinkItem, ListItem, and MenuListItem - Related parameters from builder methods - MySiteCardAndItemTest.kt (all tests were for removed properties) - Leftover Quick Start prefs from AppPrefsWrapper Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
The Quick Start removal reduced DashboardCardsViewModelSlice from 11 LiveData sources to 10. This updates the existing 10-param merge function to include the distinct parameter and proper distinct checks, matching the pattern used by other merge overloads. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
After Quick Start removal, DashboardCardsViewModelSlice uses only 10 LiveData sources. The 11-parameter merge function is no longer needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
Claude finished @nbradbury's task in 2m 2s —— View job Code Review Complete ✅I've conducted a comprehensive code review of this PR, which removes the Quick Start (onboarding walkthrough) feature. Overall, this is a well-executed large-scale feature removal with excellent cleanup. Here's my detailed analysis: SummaryThis PR successfully removes 8,731 lines of code across 139 files, eliminating the Quick Start feature completely from the WordPress and Jetpack Android apps. All CI checks are passing, and the cleanup is thorough with only minor issues remaining. Recommendation: ✅ Approve - The PR is well-structured and ready to merge after addressing the minor FluxC references noted below. Positive Highlights 🎉
Issues Found1. FluxC References Still Present (Expected, per PR description)The PR description mentions that FluxC still contains Quick Start references. I found these remaining imports from FluxC models: Files with FluxC Quick Start imports:
These import:
Impact: These files will fail to compile once FluxC's Quick Start models are removed. This is acceptable per the PR description stating "I instructed Claude not to make changes to FluxC, so references to Quick Start still appear there. If we decide to remove that, too, I can do it in a separate PR." Recommendation: Create a follow-up task to clean up FluxC references if the team decides to proceed with that cleanup. 2. Pre-existing Nullability Issues (Acknowledged, Won't Fix)CodeQL flagged 4 nullability annotation issues in Security Review ✅
Performance Review ✅
Testing Review ✅
Code Quality Review ✅Strengths:
Style observations:
Architecture Review ✅The removal properly follows the app's MVVM + FluxC architecture:
Documentation Review ✅
Recommendations
Files ReviewedCore changes reviewed:
ConclusionThis is a high-quality PR that successfully removes the Quick Start feature with minimal risk. The cleanup is thorough, all automated checks pass, and the code quality is excellent. The only remaining work is the intentional FluxC cleanup that the author plans to handle separately. Status: ✅ Ready to merge (pending smoke test confirmation) | |
|
adalpari
left a comment
adalpari
left a comment
There was a problem hiding this comment.
The log-in process looks way more clean now without these changes and the picker!!
I did some smoke tests and didn't find anything strange.
Close CMM-1130
This PR drops the "Quick Start" (walkthrough) feature that appears after logging in. Clear CI should be enough to approve this PR, but it wouldn't hurt to give the app a quick smoke test.
Note that I instructed Claude not to make changes to FluxC, so references to Quick Start still appear there. If we decide to remove that, too, I can do it in a separate PR. Also, as with previous PRs, I have not resolved any pre-existing nullability issues.
STATISTICS
COMMITS (newest first)
DELETED FILES BY CATEGORY
Quick Start UI Components (10 files):
Quick Start View Holders (2 files):
Quick Start Cards (6 files):
Quick Start Utilities (3 files):
Quick Start ViewModels (2 files):
Layout Files (12 files):
Animation Files (3 files):
Drawable Files (6 files):
Menu Files (2 files):
Test Files (5 files):
MAJOR CODE CHANGES
MySiteViewModel.kt
MySiteFragment.kt
WPMainActivity.java
MySiteCardAndItem.kt
MySiteAdapter.kt
DashboardCardsViewModelSlice.kt
LiveDataUtils.kt
SiteListItemBuilder.kt
SiteInfoHeaderCardBuilder.kt
AnalyticsTracker.java
AppPrefs.java / AppPrefsWrapper.kt
strings.xml
VERIFICATION
All checks pass: