CMM-1160: Fix WP Media Library search overlap

[nbradbury]

Description

Fixes CMM-1160

Previously, when creating a post and searching the WP Media Library with no results, the empty view is shown and the keyboard is hidden, but if the user tapped to continue typing, the keyboard would cover the empty view.

This PR fixes the problem by moving the empty view to the top so the keyboard won't cover it. I initially wasn't wild about this solution, but it turns out we already do this in the existing media search so it seemed like the right thing to do.

I also removed the image from the empty search results view as part of CMM-1037.

Testing instructions

Media picker search empty state:

1. Create or edit a post
2. Choose to add an image
3. Select the WP Media Library source
4. Search for something that returns no results and verify the empty view is shown

search.mp4

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22531-48dd1d3
	Commit	48dd1d3
	Direct Download	wordpress-prototype-build-pr22531-48dd1d3.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22531-48dd1d3
	Commit	48dd1d3
	Direct Download	jetpack-prototype-build-pr22531-48dd1d3.apk

Note: Google Login is not supported on these builds.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[nbradbury]

@claude

[claude]

Claude finished @nbradbury's task in 51s —— View job

---

Code Review Complete

• Read and analyze changed files
• Review implementation approach
• Check for potential issues
• Provide comprehensive feedback

---

Review Summary

This PR effectively solves the keyboard overlay issue by repositioning the empty view to the top of the container and removing unnecessary image elements from the search empty state. The changes are clean, focused, and well-aligned with the existing codebase patterns.

Positive Observations

✅ Clean removal of unused functionality - The PR removes image handling code (image, bottomImage, bottomImageDescription parameters) that's no longer needed, reducing complexity

✅ Simple, effective layout solution - Using app:layout_constraintVertical_bias="0" to anchor the empty view to the top is elegant and prevents keyboard overlap

✅ Consistent with existing patterns - As noted in the PR description, this approach matches the existing media search behavior

✅ Proper cleanup - Removed unused import (ActivityUtils) that's no longer needed after removing keyboard-hiding code

✅ Maintains separation of concerns - ViewModel changes are kept separate from Fragment UI logic changes

Minor Observations

Code Structure

The changes maintain good architectural patterns:

• ViewModel handles the data model (PhotoListUiModel.Empty parameters)
• Fragment handles UI presentation (setupPhotoList, applyOrHide)
• Layout XML defines the visual positioning

Testing Consideration

The PR includes clear testing instructions and a demo video. Consider verifying these scenarios:

1. Empty state appears at top when no results (✓ covered in video)
2. Keyboard doesn't cover empty view when typing continues (✓ covered in video)
3. Empty view behavior in portrait vs landscape orientations
4. Empty view with different content lengths (long titles/subtitles)

Edge Cases to Verify

While the implementation looks solid, ensure these scenarios work correctly:

1. Rotation handling - Empty view maintains top position after device rotation
2. Different screen sizes - Top-anchored view works well on both small phones and tablets
3. Accessibility - Screen readers properly announce the empty view when it appears at the top

No Issues Found

No bugs, security issues, performance problems, or code quality concerns identified. The implementation is straightforward and appropriate for the problem being solved.

---

Overall Assessment: ✅ Approved - Well-executed fix with clean code removal and proper architectural separation.

---

[adalpari]

Fair enough. LGTM!