Standardize FAB colors and icon to M3 defaults#22654
Merged
Conversation
Use consistent containerColor (onSurface) and contentColor (surface) for all Compose FABs, remove dark mode conditional in CampaignListingFragment, remove explicit backgroundTint override in media_settings_activity.xml, and add CampaignListingSuccess preview with FAB. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove explicit containerColor/contentColor overrides from all Compose FABs so they use the M3 defaults (primaryContainer/onPrimaryContainer). Standardize all create FABs to use Icons.Default.Add instead of mixing Icons.Rounded.Add. Clean up unused imports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Change WordPress.FloatingActionButton style in both light and dark themes to use colorPrimaryContainer/colorOnPrimaryContainer, matching the M3 defaults used by all Compose FABs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
The colorPrimaryContainer/colorOnPrimaryContainer attributes are not available in Theme.MaterialComponents.DayNight, causing a crash at startup. Revert to the original theme colors for XML FABs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
|
Contributor
|
|
WordPress FABs now use Automattic blue tones instead of M3 default purple. Jetpack retains the purple M3 defaults via flavor overrides. Updates both XML styles and Compose color schemes so all FAB rendering paths are consistent. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Contributor
|
Not sure if it0s a real bug, but Claude flagged this: |
adalpari
approved these changes
Mar 5, 2026
Contributor
adalpari
left a comment
adalpari
left a comment
There was a problem hiding this comment.
LGTM! Just left a minor comment
Contributor
Author
These are both defined in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes CMM-1301
Various screens throughout the app use different colors for FABs. The difference is especially noticeable between Compose and XML screens. This PR resolves this by:
primaryContainer/onPrimaryContainer) by removing explicit color overridesWordPress.FloatingActionButtonXML theme style (light + dark) to usecolorPrimaryContainer/colorOnPrimaryContainer, making all XML FABs consistentIcons.Default.AddbackgroundTintoverride from media_settings_activity.xmlTest plan
Verify the FABs on the following screens are consistent:
These two have also changed, but they can be hard to get to. I recommend relying on the previews to verify them.
Jetpack
WordPress