Skip to content

fix: open redirect_to URL in browser to prevent infinite deep link loop#22665

Merged
dcalhoun merged 1 commit intotrunkfrom
merge/release-26.6.1-into-trunk
Mar 9, 2026
Merged

fix: open redirect_to URL in browser to prevent infinite deep link loop#22665
dcalhoun merged 1 commit intotrunkfrom
merge/release-26.6.1-into-trunk

Conversation

@crazytonyli
Copy link
Copy Markdown
Contributor

This PR merges the #22648 changes in the release/26.6.1 branch to the trunk branch.


  • fix: open redirect_to URL in browser to prevent infinite deep link loop

When a tracking URL's redirect_to target can't be handled in-app, open the extracted redirect_to URL in the browser instead of the original tracking URL. This prevents an infinite loop caused by the app's intent filter re-intercepting its own public-api.wordpress.com/bar/ URLs.

  • fix: fire server tracking pixel when redirect_to opens in browser

When a tracking URL's redirect_to target can't be handled in-app, the app now opens the redirect destination in the browser (loop fix) but the server never sees the original tracking URL. Fire the pixel explicitly in this path so email link taps are still recorded.

The no-redirect fallback still opens /bar/ in the browser, which handles tracking implicitly via the browser's HTTP request.

Description

Testing instructions

…op (#22648)

* fix: open redirect_to URL in browser to prevent infinite deep link loop

When a tracking URL's redirect_to target can't be handled in-app, open
the extracted redirect_to URL in the browser instead of the original
tracking URL. This prevents an infinite loop caused by the app's intent
filter re-intercepting its own public-api.wordpress.com/bar/ URLs.

* fix: fire server tracking pixel when redirect_to opens in browser

When a tracking URL's redirect_to target can't be handled in-app, the
app now opens the redirect destination in the browser (loop fix) but
the server never sees the original tracking URL. Fire the pixel
explicitly in this path so email link taps are still recorded.

The no-redirect fallback still opens /bar/ in the browser, which
handles tracking implicitly via the browser's HTTP request.
@crazytonyli crazytonyli added this to the 26.7 milestone Mar 9, 2026
@crazytonyli crazytonyli requested a review from dcalhoun March 9, 2026 08:29
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Mar 9, 2026

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress Android by scanning the QR code below to install the corresponding build.

App NameWordPress Android
Build TypeDebug
Versionpr22665-10bbb3a
Build Number1486
Application IDorg.wordpress.android.prealpha
Commit10bbb3a
Installation URL6j607cfq4qc40
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack Android by scanning the QR code below to install the corresponding build.

App NameJetpack Android
Build TypeDebug
Versionpr22665-10bbb3a
Build Number1486
Application IDcom.jetpack.android.prealpha
Commit10bbb3a
Installation URL7m0dgb8ogro0o
Note: Google Login is not supported on these builds.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.01%. Comparing base (3757530) to head (10bbb3a).
⚠️ Report is 1 commits behind head on trunk.

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #22665   +/-   ##
=======================================
  Coverage   38.01%   38.01%           
=======================================
  Files        2268     2268           
  Lines      116715   116720    +5     
  Branches    16178    16180    +2     
=======================================
+ Hits        44371    44376    +5     
  Misses      68707    68707           
  Partials     3637     3637           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcalhoun dcalhoun merged commit fe4dc02 into trunk Mar 9, 2026
25 of 26 checks passed
@dcalhoun dcalhoun deleted the merge/release-26.6.1-into-trunk branch March 9, 2026 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants