RS Post Settings: Fix dialog selection lost on rotation#22699
Merged
RS Post Settings: Fix dialog selection lost on rotation#22699
Conversation
Use rememberSaveable instead of remember for the selected index in StatusDialog, FormatDialog, and AuthorDialog so the user's choice persists through configuration changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
4 tasks
|
Contributor
|
|
Contributor
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #22699 +/- ##
=======================================
Coverage 37.50% 37.50%
=======================================
Files 2298 2298
Lines 120741 120741
Branches 16531 16531
=======================================
Hits 45288 45288
Misses 71781 71781
Partials 3672 3672 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Description
When a user selects a new author, status, or format in the RS Post Settings dialogs and then rotates the device, the selection reverts to the original value. This happens because the dialog's local selection state uses
rememberwhich doesn't survive configuration changes.This PR changes
remembertorememberSaveableinStatusDialog,FormatDialog, andAuthorDialogso the selected index is preserved across configuration changes. The other dialogs (PasswordDialog,TextFieldDialog) already usedrememberSaveablecorrectly.Testing instructions
Dialog selection survives rotation: