Changing site settings creates an infinite request loop

[dcalhoun]

Expected behavior

Updating a single setting should result in a single POST request.

Actual behavior

Updating a single setting results in a never-ending stream of POST requests.

Steps to reproduce the behavior

1. Set up your device so that you can monitor network traffic—e.g., send device requests through Charles Proxy.
2. Navigate to My Site.
3. Tap More.
4. Scroll down and tap Site Settings.
5. Scroll down to and tap Discussion.
6. Toggle Allow Comments.

Tested on iPhone SE, iOS 18.1, Jetpack iOS / WordPress iOS 25.4.2

[dangermattic]

Thanks for reporting! 👍

[dcalhoun]

From debugging this, it appears the persist settings guard clause is insufficient. Settings are persisted anytime the context changes, which then results in the context changing again. The guard clause needs to be more robust to ensure an infinite loop is not created when the settings object is changed.