Skip to content

[Stats Refresh] Post Stats: fix Post Title display issues#11624

Merged
ScoutHarris merged 1 commit intodevelopfrom
fix/11618-post_stats_title_ui
May 3, 2019
Merged

[Stats Refresh] Post Stats: fix Post Title display issues#11624
ScoutHarris merged 1 commit intodevelopfrom
fix/11618-post_stats_title_ui

Conversation

@ScoutHarris
Copy link
Copy Markdown
Contributor

Fixes #11618

This addresses the problems noted in #11618 regarding the Post Title displayed in the title card, namely:

  • The Post Title is now dark grey
  • The font is NotoSerif-Bold
  • The spacing between the Showing stats for label and the Post Title is now consistent regardless of the post title length.

The problems stemmed from this change, where I got...creative, and made the Post Title look like that on Latest Post Summary since it's now clickable.

The fix was simply to remove the postTitleLabel.attributedText, thus allowing the original formatting to shine through.

To test:

  • Go to Post Stats, and verify the three points noted above.

single_line_title

multi_line_title

@ScoutHarris ScoutHarris added this to the 12.4 milestone May 2, 2019
@ScoutHarris ScoutHarris self-assigned this May 2, 2019
@ScoutHarris ScoutHarris mentioned this pull request May 2, 2019
45 tasks
Copy link
Copy Markdown
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ScoutHarris works good! LGTM! :shipit:

@SylvesterWilmott
Copy link
Copy Markdown

Looks good!

Can you double check the spacing between the labels when there's 1/2 lines. In the screenshots above it looks like there's around a 2pt different in spacing between the two.

@ScoutHarris
Copy link
Copy Markdown
Contributor Author

ScoutHarris commented May 3, 2019

Hey @SylvesterWilmott .

Can you double check the spacing between the labels when there's 1/2 lines. In the screenshots above it looks like there's around a 2pt different in spacing between the two.

The space between the labels is 2pts. However, the one line Post Title label is a bit spacious -

one_line

two_lines

Not sure why, but I've created #11637 to look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Stats Refresh] Post Stats: title UI issues

3 participants