[Stats Refresh] Post Stats: fix Post Title display issues#11624
Merged
ScoutHarris merged 1 commit intodevelopfrom May 3, 2019
Merged
[Stats Refresh] Post Stats: fix Post Title display issues#11624ScoutHarris merged 1 commit intodevelopfrom
ScoutHarris merged 1 commit intodevelopfrom
Conversation
45 tasks
danielebogo
approved these changes
May 3, 2019
Contributor
danielebogo
left a comment
There was a problem hiding this comment.
@ScoutHarris works good! LGTM! ![]()
|
Looks good! Can you double check the spacing between the labels when there's 1/2 lines. In the screenshots above it looks like there's around a 2pt different in spacing between the two. |
Contributor
Author
|
Hey @SylvesterWilmott .
The space between the labels is 2pts. However, the one line Post Title label is a bit spacious - Not sure why, but I've created #11637 to look at it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #11618
This addresses the problems noted in #11618 regarding the Post Title displayed in the title card, namely:
Showing stats forlabel and the Post Title is now consistent regardless of the post title length.The problems stemmed from this change, where I got...creative, and made the Post Title look like that on Latest Post Summary since it's now clickable.
The fix was simply to remove the
postTitleLabel.attributedText, thus allowing the original formatting to shine through.To test: