Skip to content

Conversation

@ScoutHarris
Copy link
Contributor

Fixes #n/a
WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#113

This enables the new enableSignInWithApple flag added in the above WPAuth, allowing the 'Continue with Apple' button to appear in the Log In button view.

apple_button

To test:

  • Run the app in XCode 11.
    • Run on iOS 13. Verify the Apple button appears.
      • Tapping the button doesn't do anything yet, but does log a Login Prologue: Apple tapped. message.
    • Run in a lower iOS version. Verify the Apple button does not appear.
  • Run the app in XCode 10.
    • Verify the Apple button never appears.
  • Disable FeatureFlag:signInWithApple.
    • Verify the Apple button never appears.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Copy link
Contributor

@astralbodies astralbodies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! That post_install hook scares me a little.

@ScoutHarris ScoutHarris merged commit 347a12f into develop Aug 19, 2019
@ScoutHarris ScoutHarris deleted the feature/show_siwa_button branch August 19, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Sign In With Apple Sign In With Apple

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants