Skip to content

Dark mode: Fix NUX sign up epilogue colors #12429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2019
Merged

Dark mode: Fix NUX sign up epilogue colors #12429

merged 2 commits into from
Aug 30, 2019

Conversation

@frosty
Copy link
Contributor

@frosty frosty commented Aug 30, 2019

Fixes #12320. This PR can also be used to verify the changes in wordpress-mobile/WordPressAuthenticator-iOS#124

This PR updates the sign up epilogue to remove white backgrounds:

Simulator Screen Shot - iPhone Xs - 2019-08-30 at 10 38 26

To test:

  • See the WPAuthenticator PR for full testing instructions.

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@frosty frosty added NUX UI User interface bugs labels Aug 30, 2019
@frosty frosty added this to the 13.2 ❄️ milestone Aug 30, 2019
@frosty frosty requested a review from danielebogo August 30, 2019 10:33
danielebogo
danielebogo approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@danielebogo danielebogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @frosty this looks great! Code looks good to me and all the screens I tested were perfect! Thanks!
:shipit:

#124 approved as well!

@frosty frosty merged commit 3eb83ca into release/13.2 Aug 30, 2019
@frosty frosty deleted the fix/nux-epilogue-dark-mode branch August 30, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielebogo danielebogo danielebogo approved these changes

Assignees

No one assigned

Labels

UI User interface bugs

Projects

None yet

Milestone

13.2 ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@frosty @danielebogo