Issue/11555 Site Creation: Space in the title/tagline doesn't appear #12564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…until you type the next letter - added a workaround for the text fiel to be able to show the spaces (spaces need to be replaced by unicode space)
frosty
suggested changes
Sep 27, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Thanks for working on this issue!
So this change does indeed fix the issue of spaces not showing in the title and tagline fields during typing. However, as we're inserting non-breaking spaces, I noticed that it causes issues with long site titles / taglines wrapping:
I think we can fix this by replacing the unicode spaces back with normal spaces in textFieldDidEndEditing. Would you be able to make that change?
…until you type the next letter - replaced unicode spaces by the normal ones to prevent incorrect word wrapping
Author
|
@frosty sure! I've pushed it to this branch. Thank you! |
frosty
approved these changes
Sep 27, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Changes look good! Thank you for fixing this!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11555
To test:
Update release notes:
RELEASE-NOTES.txtif necessary.