Do not delete revision outside from the editors #13147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since PostCoordinator is a entity that runs on background, it might end deleting a revision that is being used in the Editor, for example. We want to avoid that.
When saving a post and keeping the Editor opened, we need to apply the revision and update the post reference.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
diegoreymendez
approved these changes
Dec 20, 2019
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
The PR looks good on my end. I wasn't able to cause the crash or cause any inconsistencies in the post status. Good work @leandroalonso !
leandroalonso
deleted the
issue/12282_do_not_delete_revision_outside_from_editor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12282
To test
(If you follow these steps in
developthe app will crash)Additional information
As @etoledom mentioned the problem is not only related to Media. What was happening is that
PostCoordinatorwas deleting a revision being used by the Editor. This caused a lot of trouble.The idea of this PR is to remove this deletion from
PostCoordinatorso this problem will not happen anymore. This logic is now in the Editors.However, you can see the content in the editor blinking when the content is updated. I wonder if this is a bad experience, if it is, I'd suggest closing the Editor when the user tap "Save as Draft". I'm open to suggestions too. :)
PR submission checklist:
RELEASE-NOTES.txtif necessary.