Skip to content

Conversation

@ScoutHarris
Copy link
Contributor

Ref #12441
Auth PR: wordpress-mobile/WordPressAuthenticator-iOS#199

This uses the Auth changes that updates the Login & Signup NUXButtons when light/dark mode toggled.

NOTE: These buttons are not NUXButtons, and therefore are not fixed:

To test:

  • Log out of the app.
  • On the initial view, toggle light/dark mode.
  • Verify the buttons update accordingly.
initial_light initial_dark
  • Select 'Log In'.
  • Toggle light/dark mode.
  • Verify the buttons update accordingly (except for Apple).
login_light login_dark
  • Select 'Sign up'.
  • Toggle light/dark mode.
  • Verify the buttons update accordingly (except for Apple).
signup_light signup_dark

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added Login Signup UI User interface bugs labels Mar 11, 2020
@ScoutHarris ScoutHarris added this to the 14.5 milestone Mar 11, 2020
@ScoutHarris ScoutHarris requested a review from Gio2018 March 11, 2020 22:39
@ScoutHarris ScoutHarris self-assigned this Mar 11, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 11, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!! As usual please switch the pod reference to 1.11.0-beta.4 in the Podfile as soon as it's published.

Podfile Outdated
#pod 'Gridicons', :git => 'https://github.com/Automattic/Gridicons-iOS.git', :branch => 'feature/Swift-5-migration'

pod 'WordPressAuthenticator', '~> 1.11.0-beta.2'
# pod 'WordPressAuthenticator', '~> 1.11.0-beta.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ScoutHarris ScoutHarris merged commit ea21395 into develop Mar 12, 2020
@ScoutHarris ScoutHarris deleted the fix/12441-use_updated_nux_buttons branch March 12, 2020 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Login Signup UI User interface bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants