-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Reader: fix a glitch in the following tab #15513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…Menu to prevent the issue where the following tab is being initially laid out out of the screen
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
|
@yaelirub this call was added on purpose. Mainly, to prevent this issue: #14412 I think that if we remove this call and follow the steps described in the issue (fresh install -> Reader) the issue will happen again — and a small glitch is less problematic than waiting (sometimes seconds) for the screen to appear. |
|
@yaelirub I managed to fix. We need to change this guard: https://github.com/wordpress-mobile/WordPress-iOS/blob/develop/WordPress/Classes/ViewRelated/System/FilterTabBar.swift#L427 Basically, it should be like this: The issue is happening because this method is trying to do some calculations while the |
WordPress/Classes/ViewRelated/Reader/Tab Navigation/ReaderTabItemsStore.swift
Outdated
Show resolved
Hide resolved
and instead checking the bounds width > 0 before setting the tabs
51692ac to
13537ae
Compare
|
Thank you so so much, @leandroalonso ! I updated to your recommended. Ready of another look |
|
Done in #15536 |
Fixing an issue where the following tab is being initially laid out out off to the left of the screen
Gif of the issue:
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.