Sync comments content only if needed#17234
Merged
ealeksandrov merged 1 commit intoSep 29, 2021
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
dvdchr
approved these changes
Sep 29, 2021
dvdchr
left a comment
Contributor
There was a problem hiding this comment.
LGTM! ![]()
Tested:
- Scrolled to page two or more on the comments list, and tapped on one Comment. When going back to the list, the paging should be preserved.
Additional test scenarios:
- Comments list content snippet should reflect the updated comment data.
- Comments list should correctly remove any comment that's marked as spam or trash from the list.
Contributor
Author
|
Thanks for revew David! |
This was referenced Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17202.
Description
On each
viewWillAppearmethodsyncContentis called to reload all data, even if there is something already loaded.The fix is adding a check and call
syncContentonly when it's needed (no loaded content).To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.