Blogging Prompts Dashboard Card: hide prompt card when prompt skipped#18642
Merged
ScoutHarris merged 5 commits intotrunkfrom May 18, 2022
Merged
Blogging Prompts Dashboard Card: hide prompt card when prompt skipped#18642ScoutHarris merged 5 commits intotrunkfrom
ScoutHarris merged 5 commits intotrunkfrom
Conversation
36 tasks
Contributor
You can test the changes in WordPress from this Pull Request by:
|
wargcm
suggested changes
May 17, 2022
Contributor
wargcm
left a comment
There was a problem hiding this comment.
Hey @ScoutHarris 👋, I ran into a few issues while testing different scenarios:
| Prompt for other sites being skipped | Unable to skip prompt on other sites | Skipped prompt reappears |
|---|---|---|
|
|
|
…omID instead of the prompt's siteID.
Contributor
Author
|
Hey @wargcm . Thanks for the testing! Much appreciated. The problem was twofold:
Ready for another go if you please. You'll want to reinstall the app to purge the defective user defaults. Thank you! |
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
wargcm
approved these changes
May 18, 2022
Contributor
wargcm
left a comment
There was a problem hiding this comment.
@ScoutHarris Each of those have been fixed and I don't see any other issues. Looks good! ![]()
Contributor
Author
|
Thanks @wargcm ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #18429, #18250
When
Skip this promptis selected from the prompt dashboard:Bonus: the card will now use the cached prompt if there is one.
To test:
bloggingPromptsfeature flag.Hometab.Skip this prompt.Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.