Blogging Prompts: Add prompt metadata to prompt posts#18808
Merged
Conversation
This was referenced Jun 1, 2022
Merged
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
Contributor
|
Hey, following the testing steps, I wasn't able to trigger |
Contributor
Author
|
@alpavanoglu I thought that navigating back would trigger it but I was mistaken. I realize now those steps are incorrect after working on the prompt caching issue. One way that should trigger the |
Generated by 🚫 dangerJS |
alpavanoglu
approved these changes
Jun 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #18429
WPKit PR: wordpress-mobile/WordPressKit-iOS#515
Description
Adds prompt metadata to posts when answering a prompt in order to track if it has been answered.
Testing
Note: There's an existing caching issue where the prompt data will not update after answering the prompt. A temporary change is needed in
BloggingPromptsService.swift:// BloggingPromptsService.swift func todaysPrompt(success: @escaping (BloggingPrompt?) -> Void, failure: @escaping (Error?) -> Void) { // guard localTodaysPrompt == nil else { // success(localTodaysPrompt) // return // } fetchTodaysPrompt(success: success, failure: failure) }To test:
bloggingPromptsfeature flag inFeatureFlag.swifttodaysPrompt(switch to another blog and then back, this should call theconfiguremethod on the dashboard card which callstodaysPrompt)Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.