Skip to content

Conversation

@wargcm
Copy link
Contributor

@wargcm wargcm commented Jun 3, 2022

See: #18472

Description

Updates the entry_point strings to match Android's. Additionally, updates the prompts dashboard card entry to have a value other than dashboard.

Testing

To test:

  • Enable bloggingPrompts feature flag in FeatureFlag.swift
  • Login if necessary
  • When the prompts feature intro shows, tap on 'Try it now'
  • Select a site if necessary
  • When the editor opens, verify editor_session_start is tracked with an entry_point property matching blogging_prompts_introduction
  • Dismiss the editor
  • Navigate to the 'My Site' tab
  • Tap on 'Answer Prompt' on the prompts dashboard card
  • When the editor opens, verify editor_session_start is tracked with an entry_point property matching my_site_card_answer_prompt
  • Dismiss the editor
  • Tap on the FAB '+'
  • In the prompts action sheet header, tap on 'Answer Prompt'
  • When the editor opens, verify editor_session_start is tracked with an entry_point property matching add_new_sheet_answer_prompt
  • Dismiss the editor
  • Navigate to the 'My Site' tab
  • Set a prompts blogging reminder in 'Menu > Site Settings > Blogging Reminders' for one minute ahead of the current time and day
  • Allow push notifications if necessary
  • Background the app
  • Wait for the push notification and tap on it
  • When the editor opens, verify editor_session_start is tracked with an entry_point property matching blogging_reminders_notification_answer_prompt

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wargcm wargcm added this to the 20.1 milestone Jun 3, 2022
@wargcm wargcm requested a review from alpavanoglu June 3, 2022 18:25
@wargcm wargcm self-assigned this Jun 3, 2022
@wargcm wargcm mentioned this pull request Jun 3, 2022
14 tasks
@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18828-114e231 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18828-114e231 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@alpavanoglu
Copy link
Contributor

Test Results:
blogging_prompts_introduction
my_site_card_answer_prompt
add_new_sheet_answer_prompt
blogging_reminders_notification_answer_prompt

@wargcm wargcm merged commit 2185a1e into trunk Jun 9, 2022
@wargcm wargcm deleted the task/18472-editor-entry-point-tracks branch June 9, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants