Update various localized strings to use reverse-DNS keys #19635
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -143,18 +143,29 @@ class GrowAudienceCell: UITableViewCell, NibLoadable { | |
|
|
||
| private enum Strings { | ||
|
|
||
|
Contributor
Author
There was a problem hiding this comment. If the diff in this this file is too noisy because of the formatting and indentation changes, checkout the isolated commit that adds the reverse-DNS keys |
||
| static let viewsCountDescriptionSingular = NSLocalizedString( | ||
| "growAudienceCell.viewsCount.singular", | ||
| value: "View to your site so far", | ||
| comment: "Description for view count. Singular." | ||
| ) | ||
|
|
||
| static let viewsCountDescriptionPlural = NSLocalizedString( | ||
| "growAudienceCell.viewsCount.plural", | ||
| value: "Views to your site so far", | ||
| comment: "Description for view count. Singular." | ||
| ) | ||
|
Contributor
There was a problem hiding this comment. Unrelated to this PR, but it might be worth to explore using .stirngsdict to localize plurals. |
||
|
|
||
| static let tipTitle = NSLocalizedString( | ||
| "growAudienceCell.tip", | ||
| value: "A tip to grow your audience", | ||
| comment: "A hint to users about growing the audience for their site, when their site doesn't have many views yet." | ||
| ) | ||
|
|
||
| static let dismissButtonTitle = NSLocalizedString( | ||
| "growAudienceCell.dismiss", | ||
| value: "Dismiss", | ||
| comment: "Title for button that will dismiss the Grow Your Audience card." | ||
| ) | ||
|
|
||
| static func getViewsCountDescription(viewsCount: Int) -> String { | ||
| return viewsCount == 1 ? viewsCountDescriptionSingular : viewsCountDescriptionPlural | ||
|
|
@@ -166,63 +177,99 @@ class GrowAudienceCell: UITableViewCell, NibLoadable { | |
| } | ||
|
|
||
| enum Social { | ||
| static let detailsTitle = NSLocalizedString( | ||
| "growAudienceCell.social.title", | ||
| value: "Automatically share new posts to your social media to start bringing that audience over to your site.", | ||
| comment: "A detailed message to users about growing the audience for their site through enabling post sharing." | ||
| ) | ||
|
|
||
| static let actionButtonTitle = NSLocalizedString( | ||
| "growAudienceCell.social.actionButton", | ||
| value: "Enable post sharing", | ||
| comment: "Title for button that will open up the social media Sharing screen." | ||
| ) | ||
|
|
||
| static let completedTipTitle = NSLocalizedString( | ||
| "growAudienceCell.social.completed.title", | ||
| value: "Sharing is set up!", | ||
| comment: "A hint to users that they've set up post sharing." | ||
| ) | ||
|
|
||
| static let completedDetailsTitle = NSLocalizedString( | ||
| "growAudienceCell.social.completed.details", | ||
| value: "When you publish your next post it will be automatically shared to your connected networks.", | ||
| comment: "A detailed message to users indicating that they've set up post sharing." | ||
| ) | ||
|
|
||
| static let completedActionButtonTitle = NSLocalizedString( | ||
| "growAudienceCell.social.completed.button", | ||
| value: "Connect more networks", | ||
| comment: "Title for button that will open up the social media Sharing screen." | ||
| ) | ||
| } | ||
|
|
||
| enum BloggingReminders { | ||
| static let detailsTitle = NSLocalizedString( | ||
| "growAudienceCell.bloggingReminders.details", | ||
| value: "Posting regularly can help build an audience. Reminders help keep you on track.", | ||
| comment: "A detailed message to users about growing the audience for their site through blogging reminders." | ||
| ) | ||
|
|
||
| static let actionButtonTitle = NSLocalizedString( | ||
| "growAudienceCell.bloggingReminders.actionButton", | ||
| value: "Set up blogging reminders", | ||
| comment: "Title for button that will open up the blogging reminders screen." | ||
| ) | ||
|
|
||
| static let completedTipTitle = NSLocalizedString( | ||
| "growAudienceCell.bloggingReminders.completed.tip", | ||
| value: "You set up blogging reminders", | ||
| comment: "A hint to users that they've set up blogging reminders." | ||
| ) | ||
|
|
||
| static let completedDetailsTitle = NSLocalizedString( | ||
| "growAudienceCell.bloggingReminders.completed.details", | ||
| value: "Keep blogging and check back to see visitors arriving at your site.", | ||
| comment: "A detailed message to users indicating that they've set up blogging reminders." | ||
| ) | ||
|
|
||
| static let completedActionButtonTitle = NSLocalizedString( | ||
| "growAudienceCell.bloggingReminders.completed.actionButton", | ||
| value: "Edit reminders", | ||
| comment: "Title for button that will open up the blogging reminders screen." | ||
| ) | ||
| } | ||
|
|
||
| enum ReaderDiscover { | ||
| static let detailsTitle = NSLocalizedString( | ||
| "growAudienceCell.readerDiscover.details", | ||
| value: "Connect with other bloggers by following, liking and commenting on their posts.", | ||
| comment: "A detailed message to users about growing the audience for their site through reader discover." | ||
| ) | ||
|
|
||
| static let actionButtonTitle = NSLocalizedString( | ||
| "growAudienceCell.readerDiscover.actionButton", | ||
| value: "Discover blogs to follow", | ||
| comment: "Title for button that will open up the follow topics screen." | ||
| ) | ||
|
|
||
| static let completedTipTitle = NSLocalizedString( | ||
| "growAudienceCell.readerDiscover.completed.tip", | ||
| value: "You've connected with other blogs", | ||
| comment: "A hint to users that they've set up reader discover." | ||
| ) | ||
|
|
||
| static let completedDetailsTitle = NSLocalizedString( | ||
| "growAudienceCell.readerDiscover.completed.details", | ||
| value: "Keep going! Liking and commenting is a good way to build a network. Go to Reader to find more posts.", | ||
| comment: "A detailed message to users indicating that they've set up reader discover." | ||
| ) | ||
|
|
||
| static let completedActionButtonTitle = NSLocalizedString( | ||
| "growAudienceCell.readerDiscover.completed.action", | ||
| value: "Do it again", | ||
| comment: "Title for button that will open up the follow topics screen." | ||
| ) | ||
| } | ||
| } | ||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment in the commit: ea70a12#comments