-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Call AVCaptureSession startRunning from a background thread
#19636
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mokagio
merged 2 commits into
trunk
from
mokagio/AVCaptureSession-startRunning-on-background
Nov 24, 2022
Merged
Call AVCaptureSession startRunning from a background thread
#19636
mokagio
merged 2 commits into
trunk
from
mokagio/AVCaptureSession-startRunning-on-background
Nov 24, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xcode said: > Thread Performance Checker: -[AVCaptureSession startRunning] should be > called from background thread. Calling it on the main thread can lead to > UI unresponsiveness
crazytonyli
reviewed
Nov 22, 2022
|
|
||
| func start() { | ||
| session?.startRunning() | ||
| DispatchQueue.global(qos: .background).async { [weak self] in |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should use a serial queue to start and stop the camera session. See this Apple sample project.
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
b99fbd6 to
09f44d8
Compare
crazytonyli
approved these changes
Nov 23, 2022
Merged
3 tasks
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on #19635, Xcode reported:
Testing
I applied the code and run through the Scan QR code flow (visit this page on the desktop browser) and verified the TSAN warning was gone.
As an aside, I've been getting the following error, but I'm 99.9% sure it's unrelated to the code change:Update The reason was that I was using an A8c account, for which QR code login doesn't work.Error screenshot
Regression Notes
RELEASE-NOTES.txtif necessary. N.A.