Skip to content

Offline Mode: Analycs improvements#23011

Merged
kean merged 3 commits into
feature/offline-mode-milesone-2from
task/offline-mode-analytics
Apr 16, 2024
Merged

Offline Mode: Analycs improvements#23011
kean merged 3 commits into
feature/offline-mode-milesone-2from
task/offline-mode-analytics

Conversation

@kean

@kean kean commented Apr 15, 2024

Copy link
Copy Markdown
Contributor
  • Record assertions in Sentry: we expect the assertions to never fire as they have nearly the same severity as crashes, so I think it's OK to track them on Sentry. This way, we'll have more information about the error, including the crash log.
  • Add more assertions
  • Add tracking for every post update/create
  • Add tracking for patch and false positives data conficts

I tested how the assertions looks like in Sentry:

wpAssertionFailure("test-error", userInfo: ["user-info-key": 2])

You can find it here: JETPACK-IOS-1AC3

Error Domain=WPAssertionFailure Code=-1 "PostListViewController.swift–63: test-error" UserInfo={NSDebugDescription=PostListViewController.swift–63: test-error}

To test: n/a

Regression Notes

  1. Potential unintended areas of impact: Analytics
  2. What I did to test those areas of impact (or what existing automated tests I relied on): n/a
  3. What automated tests I added (or what prevented me from doing so): n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@wpmobilebot

wpmobilebot commented Apr 15, 2024

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23011-aa0afc1
Version24.6
Bundle IDorg.wordpress.alpha
Commitaa0afc1
App Center BuildWPiOS - One-Offs #9525
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented Apr 15, 2024

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23011-aa0afc1
Version24.6
Bundle IDcom.jetpack.alpha
Commitaa0afc1
App Center Buildjetpack-installable-builds #8569
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/offline-mode-analytics branch from 3233c4a to f68a1c1 Compare April 15, 2024 18:12

extension CrashLogging {
extension WPLoggingStack {
static let shared = WPLoggingStack()

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't use using WordPressAppDelegate.shared as it's main-thread confined.

@kean kean requested a review from momo-ozawa April 15, 2024 20:46

@momo-ozawa momo-ozawa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kean kean force-pushed the task/offline-mode-analytics branch from 85735a0 to aa0afc1 Compare April 16, 2024 20:45
@kean kean merged commit 8b39706 into feature/offline-mode-milesone-2 Apr 16, 2024
@kean kean deleted the task/offline-mode-analytics branch April 16, 2024 21:23
@momo-ozawa momo-ozawa mentioned this pull request Apr 17, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants