Offline Mode: Analycs improvements#23011
Merged
kean merged 3 commits intoApr 16, 2024
Merged
Conversation
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23011-aa0afc1 | |
| Version | 24.6 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | aa0afc1 | |
| App Center Build | WPiOS - One-Offs #9525 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23011-aa0afc1 | |
| Version | 24.6 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | aa0afc1 | |
| App Center Build | jetpack-installable-builds #8569 |
3233c4a to
f68a1c1
Compare
kean
commented
Apr 15, 2024
|
|
||
| extension CrashLogging { | ||
| extension WPLoggingStack { | ||
| static let shared = WPLoggingStack() |
Contributor
Author
There was a problem hiding this comment.
We shouldn't use using WordPressAppDelegate.shared as it's main-thread confined.
85735a0 to
aa0afc1
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I tested how the assertions looks like in Sentry:
You can find it here: JETPACK-IOS-1AC3
To test: n/a
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: