Skip to content

Conversation

@kean
Copy link
Contributor

@kean kean commented Nov 8, 2024

This PR hardcodes the icon the for WordPress.com Blog, which has 100KK subscribes because everyone new account gets auto-subscribed to it. I asked why it didn't have the icon, and apparently it's due to the old theme on the site. Since there is no effort to update it at the source, we just have to hardcode it on the client for now.

This PR also consolidated the site icon logic in SiteIconViewModel.

Screenshot 2024-11-08 at 9 43 42 AM

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

@kean kean added the Reader label Nov 8, 2024
@kean kean added this to the 25.5 milestone Nov 8, 2024
@dangermattic
Copy link
Collaborator

dangermattic commented Nov 8, 2024

1 Warning
⚠️ This PR is assigned to the milestone 25.5. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 8, 2024

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23786-0762bc4
Version25.4.2
Bundle IDorg.wordpress.alpha
Commit0762bc4
App Center BuildWPiOS - One-Offs #11016
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Nov 8, 2024

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23786-0762bc4
Version25.4.2
Bundle IDcom.jetpack.alpha
Commit0762bc4
App Center Buildjetpack-installable-builds #10056
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@kean kean force-pushed the task/hardcode-wpcom-blog-icn branch from 2b22c66 to 0762bc4 Compare November 8, 2024 17:32
@kean kean enabled auto-merge November 8, 2024 17:32
@kean kean added this pull request to the merge queue Nov 8, 2024
Merged via the queue into trunk with commit 9f88062 Nov 8, 2024
24 checks passed
@kean kean deleted the task/hardcode-wpcom-blog-icn branch November 8, 2024 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants