Skip to content

Conversation

@mokagio
Copy link
Contributor

@mokagio mokagio commented Mar 28, 2025

It was not clear whether the Notification it originally extended was the one from Foundation or from our model. But given the type is used internally and directly, that is without any reference to its container, we can simply make it a top level type and bypass the issue.

I haven't tested this on device.

Part of #24165

It was not clear whether the `Notification` it originally extended was
the one from Foundation or from our model. But given the type is used
internally and directly, that is without any reference to its container,
we can simply make it a top level type and bypass the issue.
@mokagio mokagio added this to the 25.9 milestone Mar 28, 2025
@mokagio mokagio self-assigned this Mar 28, 2025
@mokagio mokagio requested review from crazytonyli and kean March 28, 2025 05:06
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 25.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number26838
VersionPR #24354
Bundle IDorg.wordpress.alpha
Commit56db452
Installation URL2dba1asnr2730
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number26838
VersionPR #24354
Bundle IDcom.jetpack.alpha
Commit56db452
Installation URL4ts8lguuuph08
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@mokagio mokagio added this pull request to the merge queue Mar 28, 2025
Merged via the queue into trunk with commit dd672c6 Mar 28, 2025
27 checks passed
@mokagio mokagio deleted the mokagio/formattable-notifixation-fix branch March 28, 2025 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants