Remove iOS 16 and 17 availablity check#24874
Merged
crazytonyli merged 5 commits intotrunkfrom Sep 24, 2025
Merged
Conversation
Collaborator
Generated by 🚫 Danger |
crazytonyli
changed the title
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29149 | |
| Version | PR #24874 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1018bf6 | |
| Installation URL | 6oe4ih61mlqh0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29171 | |
| Version | PR #24874 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ca1d2f4 | |
| Installation URL | 1c97h7b91aec8 |
kean
reviewed
Sep 23, 2025
| let b = Float(components[2]) | ||
|
|
||
| return String(format: "#%02lX%02lX%02lX", lroundf(r * 255), lroundf(g * 255), lroundf(b * 255)) | ||
| guard let components = resolved.cgColor.components, components.count >= 3 else { |
Contributor
There was a problem hiding this comment.
(nit) I'd remove ColorGallery completely.
| } else { | ||
| content | ||
| } | ||
| content.chartXSelection(value: $selection) |
Contributor
There was a problem hiding this comment.
Please remove ChartSelectionModifier and use chartXSelection directly.
| } else { | ||
| content | ||
| } | ||
| content.presentationCompactAdaptation(.popover) |
Contributor
There was a problem hiding this comment.
Please remove PopoverPresentationModifier and use presentationCompactAdaptation directly.
| content | ||
| } | ||
| content | ||
| .popoverTip(StatsDateRangeTip(), arrowEdge: .bottom) |
Contributor
There was a problem hiding this comment.
This modifier (DateRangeTipModifier) can also be removed.
| if #available(iOS 17.0, *) { | ||
| scrollTargetBehavior(.paging) | ||
| } | ||
| scrollTargetBehavior(.paging) |
Contributor
There was a problem hiding this comment.
pagingIfAvailable can be removed.
| } else { | ||
| self | ||
| } | ||
| self.scrollClipDisabled() |
Contributor
There was a problem hiding this comment.
_scrollClipDisabled can be removed.
|
kean
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This diff is easier to review.
Description
Remove iOS 16 & 17 availability checks.
Testing instructions
It should be good to merge as long as CI passes.