Conversation
| 'iPad Pro (12.9-inch) (5th generation)' # 12.9in - 2732x2048 @ 264 ppi | ||
| 'iPhone 17 Pro Max', # 6.5in - 2688x1242 @ 458 ppi | ||
| 'iPhone 17', | ||
| 'iPad Pro 11-inch (M4)' |
There was a problem hiding this comment.
| 🚫 | Layout/TrailingWhitespace: Trailing whitespace detected. |
Generated by 🚫 Danger |
| let month = calendar.component(.month, from: date) | ||
| let year = calendar.component(.year, from: date) | ||
|
|
||
| let components: DateComponents = { |
There was a problem hiding this comment.
The entire MockStatsService is vibe-coded – do not judge too harshly.
| case let value as Bool: | ||
| return value | ||
| case let value as String: | ||
| return (value as NSString).boolValue |
There was a problem hiding this comment.
The way we set these in UI tests is with the launch arguments that support only strings [String]:
"-ff-override-New Stats", "true",
There was a recent regression in overriddenValue where it was changed to support only Bool value – incompatible with string launch arguments.
| actions.append(AnonymousAction(title: "create-mock-post") { | ||
| let post = blog.createDraftPost() | ||
| post.postTitle = "Welcome to Gutenberg" | ||
| post.content = """ |
There was a problem hiding this comment.
I relied on WireMock in Reader, but then switched to mocks in code for screenshots. For this purpose, we are not interested in testing the flows end-to-end, so there is no reason to mock the JSONs.
| .openNotification(withSubstring: "commented on") | ||
| } | ||
| notificationList.thenTakeScreenshot(5, named: "Notifications") | ||
| // // Get a screenshot of the editor with keyboard (iPad only) |
There was a problem hiding this comment.
I haven't updated the screenshot Generation for the WordPress app yet. I only focused on Jetpack.
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 29393 | |
| Version | PR #24918 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | ea7dbdd | |
| Installation URL | 0mv9roh5h8a2g |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 29393 | |
| Version | PR #24918 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | ea7dbdd | |
| Installation URL | 0k7m18jvttpq8 |
kean
force-pushed
the
task/screenshot-generation
branch
from
85de1db to
ea7dbdd
Compare
|
|
|
||
| func disableDelays() { | ||
| delaysDisabled = true | ||
| } |
There was a problem hiding this comment.
Nitpick: I don't think it's worth the trouble to call this function from the app. The MockStatsService can check for launch arguments and things internally to show data without delay.
There was a problem hiding this comment.
Good point. Yeah, it's a bit of indirection. I'll try and see if maybe UITestConfigurator could be moved to one of the frameworks.
4 participants
Changes
Note: this is an approximate list.
FeatureFlagOverrideStoreincompatible with launch arguments (Stringonly)MockStatsServiceto give a recently boost to the recent data so the numbers appear to be growingTesting
rake dependenciesrake mocks)bundle exec fastlane jetpack_screenshots(screenshotsfor WordPress)The screenshots will be under
./fastlane/jetpack_screenshotsNotes
I ran out of time, but in the future it would be ideal to:
Screenshots (taken by the script)