Conversation
Generated by 🚫 Danger |
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31564 | |
| Version | PR #25397 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 5ea404c | |
| Installation URL | 2bi1ta0eoahco |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31564 | |
| Version | PR #25397 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 5ea404c | |
| Installation URL | 0nrme5fcno7fg |
Add `isMCPAgent` and `mcpClient` properties to `ActivityActor` to surface when activity was performed by an MCP agent. Display the MCP client name (e.g. "via Claude") in both the activity list rows and detail view. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
`cp -a` copies the source directory itself into the destination when it already exists, creating `WordPress/Frameworks/v1.121.0/`. Copy contents instead so frameworks land directly in `WordPress/Frameworks/`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Use positional format specifier (%1$@) for localized string - Remove unused actorDescription(for:) method and its tests - Restore original actorSubtitle behavior for non-MCP rows - Fix shell script to copy dotfiles using cp -a dir/. pattern - Add lineLimit(1) to metadata text to prevent truncation - Improve localization comment for translator clarity Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jkmassel
force-pushed
the
jkmassel/activity-log-mcp-agent
branch
from
7f42d20 to
3e9c180
Compare
kean
left a comment
kean
left a comment
There was a problem hiding this comment.
The PR looks good, minus one potentially unrelated change. Resolving with "Comment" since the PR is in draft.
| exit 1 | ||
| fi | ||
| cp -a "${CACHE_DIR}" "${FRAMEWORKS_DIR}" | ||
| mkdir -p "${FRAMEWORKS_DIR}" |
There was a problem hiding this comment.
Is the change related to the PR?
There was a problem hiding this comment.
Only insomuch as I hit it while testing and didn't think it was worth its own PR.
| import Testing | ||
|
|
||
| class ActivityTests: XCTestCase { | ||
| struct ActivityTests { |
There was a problem hiding this comment.
Nice to see more XCTest rework.
| } | ||
| """ | ||
|
|
||
| private let activityLogExplicitlyNotMCPAgent: String = """ |
There was a problem hiding this comment.
(nit) It might be worth adding them in Resources to reduce the amount of work for the compiler and let you see these files with a JSON viewer.
There was a problem hiding this comment.
Yeah, I didn't love this either but I figured I'd leave it to match what's already there 🤷
kean
left a comment
kean
left a comment
There was a problem hiding this comment.
Please add a note to https://github.com/wordpress-mobile/WordPress-iOS/blob/trunk/RELEASE-NOTES.txt.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
|
4 participants
Summary
isMCPAgentandmcpClientproperties toActivityActorto parse new API fieldsActivityStringFormattinghelper for actor display logicdownload-gutenberg-xcframeworks.shcopying frameworks into a nested version directory (unrelated, but I needed to do it while testing)Screenshots
Linear: AIINT-290
Test plan
ActivityTestsandActivityStringFormattingTests— all passmake dependenciesand confirm nov1.x.xsubdirectory inWordPress/Frameworks/🤖 Generated with Claude Code