Stats: Enable by default, add announcement#25411
Merged
crazytonyli merged 2 commits intorelease/26.8from Mar 22, 2026
Merged
Conversation
kean
force-pushed
the
task/add-stats-anouncement
branch
from
1348cc2 to
4094682
Compare
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 31667 | |
| Version | PR #25411 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | b5a0c4c | |
| Installation URL | 784eolqu96u1g |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 31667 | |
| Version | PR #25411 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | b5a0c4c | |
| Installation URL | 6htutg3ifbo18 |
crazytonyli
reviewed
Mar 19, 2026
| } | ||
| let hostingController = UIHostingController(rootView: view) | ||
| viewController.present(hostingController, animated: true) { | ||
| UserDefaults.standard.set(true, forKey: hasShownKey) // TEMP: |
| Task { @MainActor in | ||
| await overlaysCoordinator.presentOverlayIfNeeded(in: self) | ||
| if !isReaderAppModeEnabled { | ||
| NewStatsAnnouncementPresenter.presentIfNeeded(in: self, blog: blog) |
Contributor
There was a problem hiding this comment.
Will these two modal conflict with each other, which would crash the app?
Contributor
Author
There was a problem hiding this comment.
I revisited this and simplified the implementation:
- Remove previous "New Stats" TipKit tip (no longer needed)
- Moved the new "What's New" sheet to the "Stats" screen. It will be shown for users who are not opt-in yet.
I uploaded a video showing how it works to the PR description.
Contributor
|
Version |
kean
force-pushed
the
task/add-stats-anouncement
branch
from
4094682 to
0888cb5
Compare
Collaborator
Generated by 🚫 Danger |
crazytonyli
approved these changes
Mar 22, 2026
|
crazytonyli
added a commit
that referenced
this pull request
Mar 23, 2026
Co-authored-by: Tony Li <tony.li@automattic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a simple announcement screen. Shows once. Enables the flag – use can still opt-out.
Alternatives Considered: using "Mobile Announce" tool (would've required showing to everyone including people who already have the new stats on).
Screen.Recording.2026-03-20.at.11.41.51.AM.mov