Manage Jetpack Social Connections using wpcom/v2 endpoints#25449
Draft
crazytonyli wants to merge 3 commits intotrunkfrom
Draft
Manage Jetpack Social Connections using wpcom/v2 endpoints#25449crazytonyli wants to merge 3 commits intotrunkfrom
crazytonyli wants to merge 3 commits intotrunkfrom
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
Replace the dual keyringConnectionID/connectionID system with plain connectionID throughout the publicize social sharing code. The new wpcom/v2 endpoint no longer provides keyring_connection_id, and the server-side skip metadata uses connectionID anyway.
Replace SharingSyncService with JetpackPublicizeService, which syncs connections and services via wordpress-rs wpcom/v2 endpoints and adds write operations (create, update, delete connections, fetch keyrings).
Move all publicize connection operations (create, update, delete, fetch keyrings) from SharingService/SharingServiceRemote to JetpackPublicizeService. Remove the legacy v1.1 API methods and update all Obj-C callers.
crazytonyli
force-pushed
the
task/274-jetpack-social-endpoints
branch
from
aedaeec to
a9c6be6
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/a8c/issue/CMM-274
Testing instructions