Skip to content

Revert a localizable string change#25460

Merged
crazytonyli merged 1 commit intorelease/26.8from
task/update-localized-string
Mar 26, 2026
Merged

Revert a localizable string change#25460
crazytonyli merged 1 commit intorelease/26.8from
task/update-localized-string

Conversation

@crazytonyli
Copy link
Copy Markdown
Contributor

Introduced in #25454, and caused trouble in the release process:

Inconsistencies found between 'en' and 'zh-Hant':
addSite.selfHosted.loadingSiteInfoFailure expected placeholders for [String] but found [] instead.

Introduced in #25454, and caused trouble in the release process:

> Inconsistencies found between 'en' and 'zh-Hant':
> `addSite.selfHosted.loadingSiteInfoFailure` expected placeholders for [String] but found [] instead.
@crazytonyli crazytonyli added this to the 26.8 ❄️ milestone Mar 26, 2026
@crazytonyli crazytonyli requested a review from kean March 26, 2026 20:57
@dangermattic
Copy link
Copy Markdown
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 26.8 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@sonarqubecloud
Copy link
Copy Markdown

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number31806
VersionPR #25460
Bundle IDorg.wordpress.alpha
Commit1f6e064
Installation URL3iaeekr0rbmqo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Copy Markdown
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number31806
VersionPR #25460
Bundle IDcom.jetpack.alpha
Commit1f6e064
Installation URL5vr6snp000968
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@crazytonyli
Copy link
Copy Markdown
Contributor Author

I'll merge this PR to unblock releasing a new beta.

@crazytonyli crazytonyli merged commit 61be82a into release/26.8 Mar 26, 2026
29 checks passed
@crazytonyli crazytonyli deleted the task/update-localized-string branch March 26, 2026 21:18
crazytonyli added a commit that referenced this pull request Mar 26, 2026
Introduced in #25454, and caused trouble in the release process:

> Inconsistencies found between 'en' and 'zh-Hant':
> `addSite.selfHosted.loadingSiteInfoFailure` expected placeholders for [String] but found [] instead.
github-merge-queue Bot pushed a commit that referenced this pull request Mar 26, 2026
* Show more detailed application password login errors (#25454)

* Fix colors in post inline comment section (#25456)

* Revert a localizable string change (#25460)

Introduced in #25454, and caused trouble in the release process:

> Inconsistencies found between 'en' and 'zh-Hant':
> `addSite.selfHosted.loadingSiteInfoFailure` expected placeholders for [String] but found [] instead.

* Update strings for localization

* Update app translations – `Localizable.strings`

* Update WordPress metadata translations

* Update Jetpack metadata translations

* Bump version number

---------

Co-authored-by: Tony Li <tony.li@automattic.com>
Co-authored-by: Alex Grebenyuk <alex.grebenyuk@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants