This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Framework Enhancements #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ScoutHarris
approved these changes
Jun 8, 2018
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Doing functional testing on wordpress-mobile/WordPress-iOS#9416 (obviously), but the code here looks good to me.
| @@ -0,0 +1,70 @@ | |||
| import Foundation | |||
Contributor
There was a problem hiding this comment.
I really like this extension. Cleans up the code nicely.
Contributor
Author
There was a problem hiding this comment.
Thank you Steph!!
bummytime
approved these changes
Jun 11, 2018
bummytime
left a comment
bummytime
left a comment
There was a problem hiding this comment.
Tested in wordpress-mobile/WordPress-iOS#9416 and approved here.
Everything looks 👍 in this specific PR. 
Contributor
Author
|
@bummytime + @ScoutHarris thanks a lot for the review!! |
crazytonyli
added a commit
that referenced
this pull request
Nov 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
UIImagesnippets, so that they load the Image in the actual framework's bundle.Notes:
This PR maps the Repacked version (as a dynamic framework) of the GoogleSignIn framework.
Testing:
This PR can be tested by means of the WPiOS Integration Here.
Thanks in advance!!