This repository was archived by the owner on Feb 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
NUXButton configurable using UIAppearance #10
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
00440f7
Reference updated `WordPressUI` git branch for UIImage+Asset extension
mindgraffiti d19def4
Initial changes to make `NUXSubmitButton` conform to UIAppearance cha…
mindgraffiti f42902c
Restore podfile settings
mindgraffiti 524ef64
Makes NUXButton configurable using UIAppearance
mindgraffiti 44edf1f
Delete unused image asset methods. Remove extra line (make code style…
mindgraffiti c10d3d0
Allows all standard `UIButton` buttons to be styled using UIAppearance
mindgraffiti 89cc7b5
Restore podfile.lock settings
mindgraffiti 807364b
Pod Update
mindgraffiti 2fd7815
Change `Metric` to `DefaultRenderMetrics`
mindgraffiti e5ac7a0
Add a singleton with Auth styles
mindgraffiti 2edecde
Finish authenticator style implementation for alternative login links
mindgraffiti 1fef7ae
Merge remote-tracking branch 'origin/develop' into feature/nux-button…
jleandroperez e1d3781
Code review - use `integral`
mindgraffiti 16c4724
Fix error when attempting to build for WCiOS
mindgraffiti eeba61e
Move structs and classes out of `WordPressAuthenticator.swift` and in…
mindgraffiti 6a31dea
Delete rogue line
mindgraffiti 3ed9b8b
Add missing import. Make var public.
mindgraffiti 87e916f
Fix assignment in init method
mindgraffiti b29fc12
Code review changes - move activity indicator setting to its config m…
mindgraffiti db510d5
Use shared style instead of defaultStyle
mindgraffiti abaffb0
Set the titleFont for defaultstyle
mindgraffiti 2041ab6
Set a fixed font style for NUXButton titleLabel. Leave the font uncha…
mindgraffiti 654c331
Re-set NUXButton titleLabel font to original settings
mindgraffiti 7d703e5
Update comment
mindgraffiti e730a89
Code review changes - move activityIndicator view style to `awakeFrom…
mindgraffiti 5bb5775
Merge branch 'develop' into feature/nux-button-appearance
mindgraffiti 695d8c1
Remove shadowOffset and use default set in `WordPressUI`
mindgraffiti 046625d
Change font settings for NUXButton
mindgraffiti ad03b31
Temporarily point to `WordPressUI` branch under active development
mindgraffiti 74e297b
Restore podfile to point to `WordPressUI ~> 1.0` version
mindgraffiti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why the Podfile changes so much without Podfile changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's due to all the mucking about I did with making some of the pods local. I think I need to pull the original
PodfileandPodfile.lockand overwrite the changes made in my PR.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've been working on nuking AFNetworking (with Sergio) during last Hack Week, from WordPressKit. This change is just (or should be!!) a side effect of running
pod install.No need to bring back the old Podfile.lock, this is a beautiful thing actually!!! (one less dependency).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, got it. 👍