This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add accessibility identifiers needed for UI tests #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jtreanor
approved these changes
Jun 17, 2019
Contributor
jtreanor
left a comment
jtreanor
left a comment
There was a problem hiding this comment.
This looks good @rachelmcr!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds accessibility identifiers to the prologue screen needed for signup flow UI tests (see wordpress-mobile/WordPress-iOS#11931). Also adds more options for setting accessibility identifiers to UI buttons.
In the future we may want to improve how accessibility identifiers are set on buttons, to avoid/prevent using localized strings (since these identifiers are not exposed to users and should be the same regardless of UI language, for use in tests). However, the change in this PR will make it possible to set the necessary identifiers for existing tests with minimal changes to existing buttons.
To test: