This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Update for new WPiOS colors #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- also remove the default background color from the navbar
- new animations as well
1 task
frosty
reviewed
Jun 28, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Just a couple very small comments!
| self.subheadlineColor = subheadlineColor | ||
| self.viewControllerBackgroundColor = viewControllerBackgroundColor | ||
| self.navBarImage = navBarImage | ||
| self.prologueBackgroundColor = prologueBackgroundColor ?? WPStyleGuide.wordPressBlue() |
Contributor
There was a problem hiding this comment.
Should we just set these as default parameters?
WordPressAuthenticator.podspec
Outdated
| Pod::Spec.new do |s| | ||
| s.name = "WordPressAuthenticator" | ||
| s.version = "1.5.4-beta.2" | ||
| s.version = "1.5.4-beta.3" |
Contributor
There was a problem hiding this comment.
Do you think these changes warrant a bigger version bump?
frosty
approved these changes
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes changes necessary for WPiOS to adopt a new color scheme: