This repository was archived by the owner on Feb 5, 2025. It is now read-only.
[SIWA] Show new account epilogue #117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 22, 2019
Merged
frosty
reviewed
Aug 22, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Just a couple small comments, one the same as my WPKit comment
… from WPKit, passing that to connect methods.
Contributor
Author
|
Hey @frosty . Changes made and ready for another review please. |
frosty
approved these changes
Aug 22, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Looks good, pending a potential further change to WPKit that I suggested in the associated PR.
frosty
approved these changes
Aug 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic to show the account created epilogue after a WP account is created with an Apple ID. To note, the endpoint doesn't yet support Apple, so account creation will fail, thus the epilogue won't actually show yet.
This also passes Apple specific parameters to the social connect endpoint in WPKit, although it's not used yet.
Can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#12360
Ref WPKit PR: wordpress-mobile/WordPressKit-iOS#182