This repository was archived by the owner on Feb 5, 2025. It is now read-only.
[SIWA] Sync account with host app for existing accounts #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
astralbodies
suggested changes
Sep 5, 2019
Contributor
astralbodies
left a comment
astralbodies
left a comment
There was a problem hiding this comment.
I realized after approving that there's still a case where this doesn't fix the problem. Follow these steps on an actual device and you'll see (it requires a real keychain, not the Simulator):
- User signs in with SIWA on this device or any other device. Either a dotcom account is created or it's connected to an existing one.
- Sign out of the iOS apps.
- Sign back into the iOS app.
- Apple Credentials do not include display name or e-mail address and the epilogue looks sad.
Contributor
|
@Tug is making endpoint changes to return that information to be able to be pulled from the response to push into the UI. |
ScoutHarris
changed the base branch from
fix/12442-siwa_error_alert
to
develop
astralbodies
approved these changes
Sep 5, 2019
Contributor
astralbodies
left a comment
astralbodies
left a comment
There was a problem hiding this comment.
Captain Moron can't review a PR today, apparently. All good to go!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref WPiOS issue: wordpress-mobile/WordPress-iOS#12434
The incorrect delegate method was being called with existing accounts. Now, if logging into an existing account, the
syncmethod is called (instead ofcreatedWordPressComAccount).Can be tested with WPiOS PR: wordpress-mobile/WordPress-iOS#12471