Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@jaclync
Copy link
Contributor

@jaclync jaclync commented Dec 6, 2019

Changes

I moved the color configuration for the sendCodeButton to a more appropriate function in Login2FAViewController in 2d6fd81, but forgot to call it in viewWillAppear 🤦🏻‍♀️

Testing WPiOS

Example branch: issue/wcios-1555-color-updates

  • Launch the app
  • Log in with WP.com with an account with 2FA enabled
  • Enter the email address
  • Enter the password --> should see the 2FA screen, and the "Text me a code instead" text button should have the right color

Example screenshots in WPiOS

(there is a slight change in the blue color similar to #164)

before after
Simulator Screen Shot - iPhone 8 - 2019-12-06 at 12 09 56 Simulator Screen Shot - iPhone 8 - 2019-12-06 at 12 03 58
Simulator Screen Shot - iPhone 8 - 2019-12-06 at 12 09 40 Simulator Screen Shot - iPhone 8 - 2019-12-06 at 12 04 21

@jaclync jaclync self-assigned this Dec 6, 2019
Copy link
Contributor

@frosty frosty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :)

@jaclync jaclync merged commit e5def9e into develop Dec 6, 2019
@jaclync jaclync deleted the issue/wcios-1555-more-color-fixes branch December 6, 2019 12:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants