This repository was archived by the owner on Feb 5, 2025. It is now read-only.
[VoiceOver] Login and Signup enhancements #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shiki
force-pushed
the
fix/login-voiceover-enhancements
branch
from
a5586de to
a839b76
Compare
VoiceOver auto-selects the first element in the view hierarchy. Unfortunately, the dismiss button is the first in the hierarchy since it needs to cover everything outside of the buttons view. This changes the `accessibilityElements` order so VoiceOver will prioritize the buttons view.
shiki
force-pushed
the
fix/login-voiceover-enhancements
branch
from
d159406 to
9044ce8
Compare
4 tasks
Contributor
|
Hey @shiki sure thing! sorry I was lost in my email yesterday, reviewing now 😄 |
jaclync
approved these changes
Dec 12, 2019
Contributor
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
Tested on a device, and I was able to dismiss the Log In / Sign Up sheets by either the VoiceOver escape gesture (Z) or the Dismiss button after the primary actions!
Code: ✅ (two non-blocking nits)
Testing: 💯
| open var appleTapped: (() -> Void)? | ||
|
|
||
| /// The big transparent (dismiss) button behind the buttons | ||
| @IBOutlet weak var dismissButton: UIButton! |
Contributor
There was a problem hiding this comment.
nit: could this be private?
Contributor
Author
There was a problem hiding this comment.
I don't consider access level concerns as nitpicking. I believe they're quite important. 😉 I appreciate you for pointing these out. Fixed in 59cc2ac.
| open var appleTapped: (() -> Void)? | ||
|
|
||
| /// The big transparent (dismiss) button behind the buttons | ||
| @IBOutlet weak var dismissButton: UIButton! |
Contributor
There was a problem hiding this comment.
nit: could this be private?
Contributor
Author
|
Thank you, @jaclync! 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-iOS#13062. This is a dependency of wordpress-mobile/WordPress-iOS#13067.
Changes
First Selected Element
When opening the Login or Signup dialog, the first button is now selected by VoiceOver instead of the Dismiss button.
Dismissal using Escape Gesture
I added support for dismissing the dialog using VoiceOver's escape gesture — making a Z with 2 fingers.
Testing
Login
a. The first selected (and announced) element is the first button and not the Dismiss button
b. You can dismiss dialog by using the VoiceOver escape gesture (Z)
Sign up
a. The first selected (and announced) element is the first button and not the Dismiss button
b. You can dismiss dialog by using the VoiceOver escape gesture (Z)
Submitter Checklist
RELEASE-NOTES.txtif necessary.Hi @jaclync! Can I bother you with this one? 🙂